Node rest API: put request is not updating the request data

Question

Trying to update data using PUT request. But, the data is not updating and returning the previous data in postman.

Postman put request:

http://localhost:3000/api/actors/5daa8f1c5845ad0b5826b8d9?name=Tom

Postman response:

{
    "createdAt": "2019-10-19T04:16:13.317Z",
    "updatedAt": "2019-10-19T04:16:13.317Z",
    "_id": "5daa8f1c5845ad0b5826b8d9",
    "name": "scarlett johansson",
    "birthday": "1980-10-14T00:00:00.000Z",
    "country": "usa",
    "__v": 0
}

I have also tried to use findByIdAndUpdate. Didn't get the result. Any help would be appreciated.

Controller:

exports.updateActor = async(req, res, next) => {
    try {
        const actorId = req.params.actorId;
        const data    = req.body;

        const updateActor = await Actor.findById(actorId);

        updateActor.set(data);

        const actor = await updateActor.save();

        // res.status(200).json({ message: "Data has Updated Successfully!" });
        res.send(actor);

    } catch (err) {
        res.status(500).json({ message: err.message });
    }
};

Router:

router.put('/actors/:actorId', Actor.updateActor);

score 3 · Answer 1 · answered Oct 19 '19 at 05:21

3

To resolve the ObjectId error use the below code.

var mongoose = require('mongoose');
const updateActor = await Actor.findOneAndUpdate({"_id":mongoose.Types.ObjectId(actorId)},data, { new: true });
res.send(updateActor);

answered Oct 19 '19 at 05:21

stud3nt

2,056
1
12
21

Mahesh Bhatnagar · Answer 2 · 2019-10-19T05:27:33.773

2

Please use following code for getting update data 

 Actor.findOneAndUpdate({"_id":ObjectId(actorId)},data, 
 { new: true}).then((updatedData) => {
 res.send(updatedData);
 });

edited Oct 19 '19 at 05:27

answered Oct 19 '19 at 05:07

Mahesh Bhatnagar

1,042
1
7
8

Thanks. Response code is 200. but, data is not updating in database. – tanjiya Oct 19 '19 at 05:10
Please now check – Mahesh Bhatnagar Oct 19 '19 at 05:15
const { ObjectId } = require('mongodb'); add that line – Mahesh Bhatnagar Oct 19 '19 at 05:18
I have tried the following: Actor.findOneAndUpdate({"_id":mongoose.Types.ObjectId(actorId)}, data, { new: true}).then((updatedData) => { res.send(updatedData); }); and, that works. We need to add mongoose.Types before ObjectId. – tanjiya Oct 19 '19 at 05:34

score 2 · Accepted Answer · answered Oct 19 '19 at 05:18

2

Your postman request is http://localhost:3000/api/actors/5daa8f1c5845ad0b5826b8d9?name=Tom so look like the data to update will be in req.query instead of req.body.

Note: You should put the data to update in the body instead of query like you're doing.

More info here.

answered Oct 19 '19 at 05:18

Cuong Le Ngoc

11,595
2
17
39

Solved. I have a question. The question is: if i want to send data using req.body, then what will be the procedure? – tanjiya Oct 19 '19 at 05:25
For postman you can put the data in body section like this: https://i.stack.imgur.com/kc3PD.png – Cuong Le Ngoc Oct 19 '19 at 05:35
Got it. I have tried x-url-encoded. As, updating data via query is not a good choice. – tanjiya Oct 19 '19 at 05:39

score 0 · Answer 4 · answered Oct 19 '19 at 04:58

0

exports.updateActor = async(req, res, next) => {
    try {
        const actorId = req.params.actorId;
        const data    = req.body;

        const updateActor = await Actor.update({"_id":actorId},data);


        // res.status(200).json({ message: "Data has Updated Successfully!" });
        res.send(updateActor);

    } catch (err) {
        res.status(500).json({ message: err.message });
    }
};


try thiss...

answered Oct 19 '19 at 04:58

vicky

415
2
10

response code is 200. but, data is not updating in database. Database connection is also fine. because, i can get, delete data. – tanjiya Oct 19 '19 at 05:05

Node rest API: put request is not updating the request data

4 Answers4