1

In some languages you can rename a basic type like string to something else: 

type alias UUID = String

It's still a string type, but now you can reason better about the code. Because is not all the strings in the universe.. is just UUID shape of strings. And you can spot an error faster.

I tried to do the same in graphql, but it does not work:

function UUID (){
  return new GraphQLScalarType({
    name: 'UUID',
    serialize: uidAsString => { return uidAsString },
    parseValue:  uidAsString => { return uidAsString },
    parseLiteral(ast) {

      console.log(ast)                       // log below

      if (ast.kind === Kind.GraphQLString) {
        return ast.value;
      }
      return null;
    }
  });
}

Error is: 

{
  "errors": [
    {
      "message": "Expected type UUID!, found \"what?\"; Kind is not defined",
      "locations": [
        {
          "line": 2,
          "column": 30
        }
      ]
    }
  ]
}

When console.log the ast i see this:

{
  kind: 'StringValue',
  value: 'what?',
  block: false,
  loc: { start: 41, end: 48 }
}

So what code should i have here? Im not fully understanding what im supposed to return .. and obviously ast.value is not correct.

Is it even possible to create aliases for basic types like string, int, other enums etc? Objects are already properly(specifically) named - i don't find myself needing to rename them too often.

AIon
  • 12,521
  • 10
  • 47
  • 73

1 Answers1

1

First, the log looks correct to me. You need to differentiate between the AST value (it only has a few value types) and the type of the value. So in your case the AST value is string type and your scalar is supposed to only read strings, so all good!

Second, I don't think that this line is correct: ast.kind === Kind.GraphQLString. It should be ast.kind === Kind.STRING from what I understand from the source code.

Third, is there a reason you are putting the scalar into a function instead of simply assigning it to a variable? Scalars are usually referenced directly. Here you are creating new instances of the scalar all the time when you use UUID() in your code...

const UUID = new GraphQLScalarType({

You might also want to use more validation on the string level, otherwise I would simply suggest to use the built in ID scalar.

Herku
  • 7,198
  • 27
  • 36
  • 1
    yeah thanks, about the `const UUID` thing- i was trying to resolve the ordering automatically .. i am used from pure functional languages to declare things in whatever order is most comfortable from a **cognitive-load perspective**, and **not by execution order**, and by using a function for `UUID()` i was getting the functions hoisted, which means the order in declarations does not matter.. yes is bad, figured it does not work after i found out that calling `UUID()` produces a new value every time. That was kind of unexpected :)) – AIon Oct 07 '19 at 16:00