Do not declare C-style arrays, use std::array<> instead

Question

From clang-tidy I get for

struct Foo {
private:
  static constexpr char BAR[] = "\033[2J";
};

the warning

do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

for BAR.

How can I declare with

#include <array>
struct Foo {
private:
  static constexpr std::array<char,7> BAR // = ???
};

Thanks

(You probably don't want to omit the trailing `\0` but the dupe shows how that is accomplished too). — Max Langhof, Sep 26 '19 at 17:01

score 3 · Answer 1 · answered Sep 26 '19 at 16:54

3

That's just:

std::array<char, 5> BAR{ '\033', '[', '2', 'J', 0 };

answered Sep 26 '19 at 16:54

KamilCuk

2

This works but is needlessly verbose. You can just do `... BAR{"\033[2J"};`. – Max Langhof Sep 26 '19 at 16:58

1 Answers1