Initialize a command in Spigot

Question

I'm learning Spigot and many tutorials say to use this syntax to initialize a command.

    private Main plugin;

public Constructor(Main plugin) {
    this.plugin = plugin;
    plugin.getCommand("command").setExecutor(this);
}

But my Java knowledge is telling me that this would work as well.

    public Command(Main plugin) {
    plugin.getCommand("command").setExecutor(this);
}

Is there any difference between the two? Why would one be better to use than the other? Please don't answer with preferences, only pros and cons, or if they do the same thing.

You need to post more code. We can't tell which would work with just what you posted. — Joseph Sible-Reinstate Monica, Sep 21 '19 at 18:56
@JosephSible If I posted any more code it would go into the specifics of the command, not the initialization, which would distract from the question. — GhostCoder256, Sep 22 '19 at 13:26

score 0 · Accepted Answer · answered Sep 26 '19 at 05:41

I guess those names are just placeholders? Than: yes both will work. I would still recommend you the upper one. Most of the time you will have a lot of data manager classes e.g. a PlayerManager storing your custom player data. You could of course make everything static inside the Manager or make it a singleton, but it's better to initialize it in the on enable method to allow '/reload' to work properly and because you would probably want to inject the main there too. Back to why store the main. If you got your main stored in the command you can e.g. simply do 'main.getPlayerManager()' and don't have to use any static work arounds.

There is also another way of injecting commands. You could add the command via reflection into the command map, which would not require you to.define the command in the plugin.yml.

the first code is an class variable, you can reuse the `Main` instance. The second wont be acessible in outer methods because it is just in local scope. — Jonas, Oct 01 '19 at 05:34

Initialize a command in Spigot

1 Answers1