What is wrong with onDestroyView() method?

Question

I am trying to save values in my pref before fragment is destroyed but an error message says

android.support.v4.app.SuperNotCalledException: Fragment did not call through to super.onDestroyView()

here is my code

@Override
public void onDestroyView() {
    pref3.edit().clear().commit();
    for (int i = 0; i < movies1.size(); i++) {
        favouritemovies1.add(movies1.get(i));
        SharedPreferences.Editor editor3 = pref3.edit();
        editor3.putStringSet("favouritemovies", favouritemovies1);
        editor3.commit();
        Toast.makeText(getActivity(), "destroyed", Toast.LENGTH_SHORT).show();
        super.onDestroyView();

    }
}

when I comment for loop every thing works fine!

Move this line super.onDestroyView(); to first line. – Rajnish suryavanshi Sep 21 '19 at 09:41 — Rajnish suryavanshi, Sep 21 '19 at 09:41
You need to remove "super.onDestroyView();" from the loop. – Vishal Sojitra Sep 21 '19 at 09:41 — Vishal Sojitra, Sep 21 '19 at 09:41

score 3 · Accepted Answer · edited Oct 30 '21 at 09:19

Just keep the super.onDestroyView(); out of the for loop and inside the @Override method like this:-

   @Override
    public void onDestroyView() {
        // or here 
        pref3.edit().clear().commit();
        for (int i = 0; i < movies1.size(); i++) {
            favouritemovies1.add(movies1.get(i));
            SharedPreferences.Editor editor3 = pref3.edit();
            editor3.putStringSet("favouritemovies", favouritemovies1);
            editor3.commit();
            Toast.makeText(getActivity(), "destroyed", Toast.LENGTH_SHORT).show();
    
        }
        super.onDestroyView();
    }

score 2 · Answer 2 · edited Oct 30 '21 at 09:19

Remove super.onDestroyView(); from the loop and write it in the top like following.

@Override
public void onDestroyView() {
    super.onDestroyView();
    pref3.edit().clear().commit();
    for (int i = 0; i < movies1.size(); i++) {
        favouritemovies1.add(movies1.get(i));
        SharedPreferences.Editor editor3 = pref3.edit();
        editor3.putStringSet("favouritemovies", favouritemovies1);
        editor3.commit();
        Toast.makeText(getActivity(), "destroyed", Toast.LENGTH_SHORT).show();
        

    }
}

What is wrong with onDestroyView() method?

2 Answers2