Astyle code formatting

Question

I'm writing a linux kernel module, and trying to use astyle to help me follow the coding standard. It seems to be formatting a spi_driver structure incorrectly and I'm wondering if anyone knows why. This is the code before passing to astyle (with the command astyle --style=linux lightmod.c):

static struct spi_driver light_driver = {
    .driver = {
            .name = "light",
            .owner = THIS_MODULE,
    },
    .probe = light_probe,
    .remove = __devexit_p(light_remove),
};

And this is the output:

static struct spi_driver light_driver = {
    .driver = {
            .name = "light",
            .owner = THIS_MODULE,
    },
    .probe = light_probe,
             .remove = __devexit_p(light_remove),
               };

Why is it indenting .remove this way? Does anyone know?

I took the liberty of adding an `[astyle]` tag and adding a link. Please verify that I linked to the right thing. :) — Jeff Mercado, Apr 26 '11 at 19:27
If your code uses tabs, you might want to replace them for spaces before using astyle. Or maybe there's an option in astyle to let it be aware of tabs. — karlphillip, Apr 26 '11 at 19:49
my code does use spaces, not tabs; so that isn't it. also, the link is correct, thank you. — Woodrow Douglass, Apr 26 '11 at 20:12
What version of astyle? 1.24 does a better job, but still not 100%. — ergosys, Apr 26 '11 at 20:54

score 1 · Accepted Answer · answered Apr 26 '11 at 20:23

1

I don't think that there is a deep reason for this. Astyle simply seems not be able to handle C99's designated initializers correctly. If you use oldstyle initializers it formats them fine.

answered Apr 26 '11 at 20:23

Jens Gustedt

76,821
6
102
177

2

This is still true in 2017. – sherrellbc Jul 26 '17 at 19:50

Astyle code formatting

1 Answers1