Unable to find NavController that's inside a DialogFragment

Question

I have a BottomSheetDialogFragment that contains a NavHostFragment like so:

<layout xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:app="http://schemas.android.com/apk/res-auto">

    <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent">

        <fragment
                android:id="@+id/add_feeling_nav_host_fragment"
                android:name="androidx.navigation.fragment.NavHostFragment"
                android:layout_width="match_parent"
                android:layout_height="0dp"
                app:defaultNavHost="true"
                app:navGraph="@navigation/add_feeling_graph" />

    </LinearLayout>
</layout>

When I try to get the NavController in it's class using either of the following:

activity?.findNavController(R.id.add_feeling_nav_host_fragment)
view.findNavController()

The first option crashes because it cannot find the ID and the second one does finds a parent Nav Controller and uses that.

I have an identical setup for another Fragment however it's not a dialog and it works perfectly. Any ideas to what the issue could be? Thanks

@PavSidhu please show us the nav graph containing dialog fragment — user158, Sep 23 '19 at 09:10

score 5 · Answer 1 · answered Sep 23 '19 at 13:38

activity?.findNavController(R.id.add_feeling_nav_host_fragment) won't do the job - it will work only if the dialog fragment is active(showing) and it is a part of activity`s UI container - DialogFragment works in other instance of window that is not within the same hierarchy with the root nav graph.

Appropriate way to do it - with NavHostFragment.findNavController(fragment) or ktx extension fragment.findNavController() where fragment is your dialog fragment. The dialog fragment should be showing with its view inflated. The best way to do it - within the dialog.

Navigation graph adjustments may also be required - I cannot tell exactly since there is no code.

Hope it helps.

Kebab Krabby · Answer 2 · 2019-09-24T08:24:24.093

-1

Well, first of all you should post more code for us to see the whole picture. One small detail is that you dont need neither <layout> and <LinearLayout> in navigation xml. Fragment is just ok. I will suggest you to look at this repository, there is exactly solution you need.

I Hope it helps.

edited Sep 24 '19 at 08:24

answered Sep 23 '19 at 15:08

Kebab Krabby

1,574
13
21

Unable to find NavController that's inside a DialogFragment

2 Answers2