how to get one item of the list in a foreach ViewBag mvc 5

Question

I want to get all the student have the ContractStatus == "Pending" in foreach and make a link to Edit the student

<div class="row">
     @{ foreach (var studentCohort in ViewBag.CohortSubscriptionId)
         {
         <div class="col-md-5">
              @{

                 var link = Html.ActionLink((string) studentCohort.ContractStatus, "Edit", "CohortSubscriptions", new { id = (object) studentCohort.ContractStatus }, new { @class ="form-control"});

                 var contractStatus = studentCohort.ContractStatus == "Pending" ? link : studentCohort;
               }

               @studentCohort.FullName  (@studentCohort.contractStatus)
          </div>
          }
      }
</div>

public ActionResult Details(int? id)
        {
            if (id == null)
            {
                return new HttpStatusCodeResult(HttpStatusCode.BadRequest);
            }
            Cohorts cohorts = db.Cohorts.Find(id);
            if (cohorts == null)
            {
                return HttpNotFound();
            }

            var studentByCohort = db.Enrolled_Students.Where(x => x.CohortId == id).Select(x => new StudentCohortViewModel
            {
                CohortId = x.CohortId,
                FirstName = x.FirstName,
                LastName = x.LastName,
                ContractStatus = x.ContractStatus

            }).Distinct().ToList();
            ViewBag.CohortSubscriptionId = studentByCohort;

            return View(cohorts);

Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: ''CodeboxxSchoolPortal.Models.StudentCohortViewModel' does not contain a definition for 'contractStatus''

We need more code to help you out. The code for `StudentCohortViewModel` would greatly help. — Paul Carlton, Aug 30 '19 at 18:27
Why not using `View Model` instead ? https://stackoverflow.com/questions/32906975/passing-a-model-object-through-viewbag — Cuppyzh, Aug 30 '19 at 18:52

score 0 · Answer 1 · answered Aug 30 '19 at 18:42

0

change

(@studentCohort.contractStatus)

to

(@studentCohort.ContractStatus)

in your Razor view.

answered Aug 30 '19 at 18:42

Josie G. Bigler

367
4
14

I have already tried this, yes it gives me the ContractStatus but when the status is "Pending"' is not a link like i want – Frankthetank Aug 30 '19 at 18:46
change `(@studentCohort.contractStatus)` to `(@contractStatus )` – Josie G. Bigler Aug 30 '19 at 18:48
"(XXXX.Models.StudentCohortViewModel)" i see that – Frankthetank Aug 30 '19 at 18:52
Even for ones that are Pending? For all Students you see that? – Josie G. Bigler Aug 30 '19 at 18:54
1

`var contractStatus = studentCohort.ContractStatus == "Pending" ? link : studentCohort;` this is the problem statement in your code. – Josie G. Bigler Aug 30 '19 at 18:58
how you write it? – Frankthetank Aug 30 '19 at 19:03

score 0 · Accepted Answer · answered Aug 30 '19 at 20:44

Your choice in variable names and reassignments are hurting you here. Consequently, you're getting your types mixed and the errors you experience.

Instead of the ternary conditional (c ? a : b), I suggest using basic if/else which is easier to read and write.

<div class="row">
    @foreach(StudentCohortViewModel studentCohort in ViewBag.CohortSubscriptionId)
    {
        if (studentCohort.ContractStatus == "Pending")
        {
            <text>
                @studentCohort.FullName (@Html.ActionLink(studentCohort.ContractStatus,
                                               "Edit",
                                               "CohortSubscriptions",
                                               new { id = student.ContractStatus },
                                               new { @class = "form-control" }))
            </text>
        }
        else
        {
            <text>
                @studentCohort.FullName (@studentCohort.ContractStatus)
            </text>
        }
    }
</div>

To help with identifying the correct type, instead of var studentCohort use the more explicit StudentCohortViewModel studentCohort.

I made some changes to your code, but it works thanks a lot – Frankthetank Sep 03 '19 at 12:56 — Frankthetank, Sep 03 '19 at 12:56

how to get one item of the list in a foreach ViewBag mvc 5

2 Answers2