NavController crashes upon orientation change

Question

I'm not really sure what I'm doing wrong here. Simple setup, single activity with fragments controlled by a bottom bar inside, so far so good. The start fragment has a button inside which should navigate to another fragment.

Here's the onclicklistener for the button inside my fragment class:

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
    super.onViewCreated(view, savedInstanceState)
    add_step_fab.setOnClickListener {
        Navigation.findNavController(view).navigate(R.id.fragmentAtoB)
    }
}

Here's my action in the navigation.xml:

<fragment android:id="@+id/navigation_main" android:name="com.test.test.fragments.AFragment"
          android:label="Fragment A" tools:layout="@layout/fragment_a">
    <action android:id="@+id/fragmentAtoB"
            app:destination="@id/fragmentB" app:enterAnim="@anim/nav_default_enter_anim"
            app:exitAnim="@anim/nav_default_exit_anim" app:popEnterAnim="@anim/nav_default_pop_enter_anim"
            app:popExitAnim="@anim/nav_default_pop_exit_anim"/>
</fragment>

The navigation works, but I get the standard

java.lang.IllegalArgumentException: navigation destination com.test.test:id/fragmentAtoB is unknown to this NavController

error when I click on the button after rotating my screen, split screening the app, or sometimes seemingly randomly. Looks like it has something to do with the configuration change?

EDIT: I also tried using

val clickListener: View.OnClickListener = Navigation.createNavigateOnClickListener(R.id.fragmentAtoB)
    add_step_fab.setOnClickListener(clickListener)

with the same issue as above.

Checking if i'm actually in the same fragment, as some suggested for users who are having the same exception (but for unrelated reasons), such as:

if (controller.currentDestination?.id == R.id.navigation_main) {
            controller.navigate(R.id.fragmentAtoB)
        }

also didn't help.

score 7 · Accepted Answer · answered Feb 17 '20 at 20:11

I also experienced this recently after months of an app working correctly. I originally had added navigation to an app that was utilizing a "MainActivity" class and then had other activities that would be launched from a menu (as opposed to having the Navigation component navigate between fragments off of a single Activity).

So the app is organized such that the MainActivity is the "hub", and choices from menu options cause other activities to be launched, and when the user returns from them they are back at the MainActivity - so a pure "hub (MainActivity) and spoke (5 other activities)" model.

Within MainActivity.onCreate() is called a setupNavigation() method which originally looked like:

private void setupNavigation() {
    Toolbar toolbar = findViewById(R.id.toolbar);
    setSupportActionBar(toolbar);

    drawerLayout = findViewById(R.id.drawer_layout);

    // This class implements the listener interface for the NavigationView, handler is below.
    NavigationView navigationView = findViewById(R.id.nav_view);
    navController = Navigation.findNavController(this, R.id.nav_host_fragment);
    NavigationUI.setupActionBarWithNavController(this, navController, drawerLayout);
    NavigationUI.setupWithNavController(navigationView, navController);

    // MainActivity implements the listener for navigation events
    navigationView.setNavigationItemSelectedListener(this);

}

As I mentioned, this was working just fine even with configuration changes until recently. Even just changing the configuration from portrait to landscape on the MainActivity would cause an exception:

ComponentInfo{com.reddragon.intouch/com.reddragon.intouch.ui.MainActivity}: java.lang.IllegalStateException: You must call setGraph() before calling getGraph()

I found I had to add this line:

navController.setGraph(R.navigation.nav_host);

Right after the Naviation.findNavController() call, and then it handled configuration changes just fine.

Using `setGraph` method with the navigation file fixed the problem for me, too! — Andreas, Mar 06 '20 at 19:59
Yes, this is really a solution in case of navigation inside one page of ViewPager (https://stackoverflow.com/questions/52630267/how-to-implement-a-viewpager-using-new-navigation-architecture-component#answer-61278750). Thanx!! — chatlanin, Apr 18 '20 at 08:21
"Right after the Naviation.findNavController() call, and then it handled configuration changes just fine." - this is correct!!! — Doctiger, Jul 01 '20 at 08:03

score 0 · Answer 2 · answered Aug 16 '19 at 16:54

0

After a configuration change, the fragment or activity goes out of scope temporarily and then executes an onResume() override. If you have anything which is initialized in onCreate(), or onViewCreated(), then those variables may have gone out of scope and are now null values. So, I usually have a method called RestoreAll() which is responsible for instantiating all of the objects used by the code, and I call this method from onResume() so that every time there is a configuration change, all the local objects are re-instantiated.

answered Aug 16 '19 at 16:54

Michael Dougan

1,698
1
9
13

There must be a way to handle onclicks in a lifecycle-aware way with jetpack tho? After all, the whole premise of most jetpack architecture components is to stop thinking about fragment and activity lifecycles – just_deko Aug 16 '19 at 17:07
We'll have to wait to hear from someone more familiar with jetpack architecture. I've just used this method of insurance as a given in all of my app development, and haven't had any issues since. – Michael Dougan Aug 16 '19 at 17:19
So I just checked out some examples and they work perfectly fine with the navigation in the oncreateview. Something really weird is going on here so I think I'll make a bounty tomorrow with a bit more code – just_deko Aug 17 '19 at 11:41
Use Android ViewModel instead – IgorGanapolsky Nov 07 '19 at 19:26

score 0 · Answer 3 · answered Jan 30 '20 at 13:41

0

There is a problem with nav controller backstack after changed config. Try this: https://stackoverflow.com/a/59987336/5433148

answered Jan 30 '20 at 13:41

Daniel Pína

348
2
7

NavController crashes upon orientation change

3 Answers3