can't apply custom validation to requestParam

Question

I have my RequestParam and I need to validate it, but mu custom validation don't apply, my controller

@RestController
@Validated
class ExchangeController {

    private static final Logger logger = Logger.getLogger(ExchangeController.class.getName());

    @SuppressWarnings("SpringJavaAutowiredFieldsWarningInspection")
    @Autowired
    @Qualifier("dataService")
    private CurrencyExchangeService currencyExchangeService;

    @RequestMapping(value = "/", method = RequestMethod.GET, produces = "application/json")
    public Object converting(@RequestParam("fromCurrency") @NotNull @CurrencyValidation String fromCurrency,
                             @RequestParam("toCurrency") @NotNull String toCurrency,
                             @RequestParam("amount") @NotNull String amount) throws IOException {
        BigDecimal convertedAmount = currencyExchangeService.convert(fromCurrency, toCurrency, new BigDecimal(amount));
        return new ExchangeRateDTO(fromCurrency, toCurrency, new BigDecimal(amount), convertedAmount);

    }
}

and custom validation

public class ConstractCurrencyValidator implements
            ConstraintValidator<CurrencyValidation, String> {
        @Override
        public void initialize(CurrencyValidation currency) {
        }

        @Override
        public boolean isValid(String currency, ConstraintValidatorContext constraintValidatorContext) {
            return currency != null && Currency.getAvailableCurrencies().contains(Currency.getInstance(currency));
        }
    }

Post your `CurrencyValidation` class and what is your expected outcome here? — rimonmostafiz, Jul 29 '19 at 13:48
@rimonmostafiz I'm expect that if I input not currency I will receive 400 error — qwerty, Jul 29 '19 at 13:57
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/197165/discussion-between-rimonmostafiz-and-qwerty). — rimonmostafiz, Jul 29 '19 at 14:12
@qwerty you need an `@valid` for the validations to usually work on the pathparameters. Let me know if that solved your issue — Coder, Jul 29 '19 at 15:28
Your method should typically look like ```public Object converting(@Valid @RequestParam("fromCurrency") @NotNull @CurrencyValidation String fromCurrency...``` — Coder, Jul 29 '19 at 15:31

score 5 · Accepted Answer · answered Jul 30 '19 at 07:51

5

need to put an annotation in my @interface CustomValidation. This means that validation can also be used on the parameter.

@Target({ ElementType.PARAMETER })

answered Jul 30 '19 at 07:51

qwerty

123
9

Include all this in your question, so that it might help someone in the future – Coder Jul 31 '19 at 14:14

score 1 · Answer 2 · answered Jul 29 '19 at 14:40

Enable parameter validation in config:

 @Bean
public Validator validator() {
    return new LocalValidatorFactoryBean();
}

@Bean
public MethodValidationPostProcessor methodValidationPostProcessor() {
    MethodValidationPostProcessor methodValidationPostProcessor = new MethodValidationPostProcessor();
    methodValidationPostProcessor.setValidator(validator());
    return methodValidationPostProcessor;
}

can't apply custom validation to requestParam

2 Answers2