NSIS cancel messagebox with bad content

Asked Jul 24 '19 at 09:31

Active Jul 25 '19 at 06:28

Viewed 128 times

I have page where I download some files. Sometimes, when I press cancel in this page, I see MessageBox with bad text, look likes some numbers or some parts of word. But I used MUI_ABORTWARNING_TEXT.

Why I see bad text instead my ABORTWARNING_TEXT?

!define MUI_ABORTWARNING_TEXT "Are you sure you want to quit ${PRODUCT_NAME} Setup?"
!define MUI_CUSTOMFUNCTION_ABORT "CustomAbort"

Function CustomAbort

        ${If} ${Cmd} `MessageBox MB_YESNO "${MUI_ABORTWARNING_TEXT}" IDYES`
        # do smth
        ${Else}
        Abort
        ${EndIf}

    FunctionEnd

enter image description here

edited Jul 25 '19 at 06:28

asked Jul 24 '19 at 09:31

Катерина Романюк

Which download plug-in are you using? – Anders Jul 24 '19 at 09:52
I used ExecDos::exec – Катерина Романюк Jul 24 '19 at 11:55
Please post your ExecDos command. – Anders Jul 24 '19 at 12:28
ExecDos::exec /NOUNLOAD /ASYNC /TOFUNC `${TEMPDIR}\wget -S --tries=3 --timeout=5 --no-check-certificate --http-user=******* --http-password=****-O ******"$THIS_SERVER_HTTPS:$THIS_PORT/win$THIS_ARCH$THIS_SPECIFIER?script_version=$THIS_SCRIPTVERSION&version=$THIS_OSVERSION&hostname=$THIS_HOSTNAME"` "" $R2 – Катерина Романюк Jul 24 '19 at 14:15
1

And this message is in a popup? Can you post a screenshot? – Anders Jul 24 '19 at 14:28
1

I posted a screenshot above. But this message can be with other numbers or some text. – Катерина Романюк Jul 25 '19 at 06:33
To narrow it down, can you put MessageBoxes before and after ExecDos: `MessageBox mb_ok "Before" ExecDos::... MessageBox mb_ok "After"` (on separate lines) and verify that the strange MessageBox occurs between those two? I will investigate ExecDos tonight... – Anders Jul 25 '19 at 08:48
I think it can be because I used BgWorker::Call Wait for download. It can change stack or global variables and messagebox shows bad string in this moment. How is stack behavior in async mode? – Катерина Романюк Jul 25 '19 at 11:43
The main thread does nothing while waiting but maybe there is a incompatibility between BgWorker and ExecDos (unlikely). Why can't you use InetC instead of ExecDos + wget? And why /ASYNC if it is already on a background thread? – Anders Jul 25 '19 at 12:03

NSIS cancel messagebox with bad content

0 Answers0