Qt model drag & drop - Unable to save type QJsonValue

Question

I have a QAbstractListModel to display a QJsonArray, with drag & drop implementation:

class NoteListModel : public QAbstractListModel
{
    Q_OBJECT

public:
    explicit NoteListModel(QObject *parent = nullptr);
    ~NoteListModel() override;
    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
    QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
    Qt::ItemFlags flags(const QModelIndex& index) const override;
    // Drag & Drop:
    bool canDropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) const override;
    bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override;
    QStringList mimeTypes() const override {
        QStringList mimes = QAbstractListModel::mimeTypes();
        mimes.prepend("application/flynote_json");
        return mimes;
    }
    QMimeData *mimeData(const QModelIndexList &indexes) const override;
    Qt::DropActions supportedDropActions() const override;

private:
    QJsonArray noteArray;

};

When I call the base implementation in my mimeData() method, I have this error:

QVariant::save: unable to save type 'QJsonValue' (type id: 45)
ASSERT failure in QVariant::save: "Invalid type to save"

QMimeData *NoteListModel::mimeData(const QModelIndexList &indexes) const
{
    QMimeData *ret = nullptr;
    if (indexes.size() == 1){
        QModelIndex mi = indexes.first();
        if (mi.isValid()){
            ret = QAbstractListModel::mimeData(indexes);
            QJsonDocument json_mime(noteArray.at(mi.row()).toObject());
            ret->setData("application/flynote_json", json_mime.toJson());
        }
    }
    return ret;
}

So no problem, like is describe in the doc I add these lines:

// In the header (outside the class)
Q_DECLARE_METATYPE(QJsonValue)
QDataStream &operator<<(QDataStream &out, const QJsonValue &myObj){ /*...*/ }
QDataStream &operator>>(QDataStream &in, QJsonValue &myObj){ /*...*/ }

// In the constructor
qRegisterMetaType<QJsonValue>("QJsonValue");
qRegisterMetaTypeStreamOperators<QJsonValue>("QJsonValue");

But I have the same problem, What I'm doing wrong ?

How is your `mimeTypes()` implemented? – Silvano Cerza Jul 17 '19 at 15:34 — Silvano Cerza, Jul 17 '19 at 15:34

Aleph0 · Answer 1 · 2019-07-19T09:24:48.820

3

I tried to reproduce your example, because I really couldn't explain this behavior by looking at your code. I compiled the project with Qt 5.5 and I was able to reproduce the error message:

QVariant::save: unable to save type 'QJsonValue' (type id: 45).

Interestingly, the error vanishes with Qt 5.13, as QVariant already includes the QJson-Types in this version.

It seems, that I found a possible workaround for this kind of defect, which is the following:

#include <QApplication>
#include <QDebug>
#include <QDataStream>
#include <QJsonDocument>

QDataStream& operator<<(QDataStream& out, const QJsonDocument& myObj) {
    return out;
}

QDataStream& operator >> (QDataStream & in, QJsonDocument& myObj) {
    return in;
}
Q_DECLARE_METATYPE(QJsonDocument)


int main(int argc, char** args) {
    qDebug() << qRegisterMetaTypeStreamOperators<QJsonDocument>();
    QVariant var = QVariant::fromValue(QJsonDocument());
    qDebug() << var.type();
    qDebug() << var.typeName();
    QDataStream stream;
    var.load(stream);   // Workaround: Just call load at least once before any save 
    var.save(stream);
    var.save(stream);
}

If you call load at least once before all calls of save the error vanishes. At least for Qt 5.5.

Unfortunately, I don't have the sources of Qt 5.5 at hand to really find the reason for this odd behavior. I also don't know what makes QJsonDocument so special among other classes, which don't need the call to load.

edited Jul 19 '19 at 09:24

answered Jul 19 '19 at 07:58

Aleph0

5,816
4
29
80

1

Thank you for the help, which qt version do you use ? Because I think that in the 5.13, QJsonValue is already define in qmetatype but not in 5.9, but maybe I'm wrong. I go check – thibsc Jul 19 '19 at 08:10
@ThibautB.: That's a good point. I'm using Qt 5.13.0 and have not considered what might happened in older versions. In this case you might need to define all this operators for all QJson-Kind Objects. There are quite plenty of them. Maybe you can try to run my example. It should be self-contained. – Aleph0 Jul 19 '19 at 08:12
this is not the problem, in the 5.9 source, QJsonValue is declared [here](https://github.com/qt/qtbase/blob/5.9/src/corelib/kernel/qmetatype.h#L117), I am going to try your example – thibsc Jul 19 '19 at 08:20
Oh, Sorry, my last comment is false, in the cpp file, when it's a QJsonValue, the switch return [false in 5.9](https://github.com/qt/qtbase/blob/5.9/src/corelib/kernel/qmetatype.cpp#L1347), but in [5.13](https://github.com/qt/qtbase/blob/5.13/src/corelib/kernel/qmetatype.cpp#L1573), the implementation is different and return false only if the pointer is not allocate, that explain why it is working in your case. – thibsc Jul 19 '19 at 08:33
@ThibautB.: Alright! I rebuild my project with Qt 5.5 and I was able to reproduce your error. Hooray! – Aleph0 Jul 19 '19 at 08:49
1

@ThibautB. I updated my answer. You might want to take a look at it. – Aleph0 Jul 19 '19 at 09:25
I have test your code, effectively, the error vanishes when you call `load`, but when you try after the `save` to display the stream content (`qDebug() << stream;`) it's written *"QVariant(Invalid)"* – thibsc Jul 19 '19 at 11:43

Qt model drag & drop - Unable to save type QJsonValue

1 Answers1