How to Manipulate TableView from another Controller?

Question

Note: AlbumAvailble is a ComboBox contains the Albums of a Singer. :AvailableSinger a ComboBox dontains the Singers.

I'm trying to display songs of an album in TableView in a different dialog which is "DisplaySongs.fxml".

I've tried to create a method in "DisplaySongs.java" controller of "DisplaySongs.fxml" to add all album songs to the table. so in the method which will display the dialog I've passed the selectedItem of AlbumAvailble and get the songlist of it.

the main window controller:

@FXML
public void Display() {
    Dialog<ButtonType>DisplaySong = new Dialog<>();
    DisplaySong.initOwner(DisplayBorder.getScene().getWindow());
    DisplaySong.setTitle("DisPlay Songs");
    FXMLLoader fxmlLoader = new FXMLLoader();
    fxmlLoader.setLocation(getClass().getResource("DisplaySongs.fxml"));
    try {
        DisplaySong.getDialogPane().setContent(fxmlLoader.load());
    }catch (IOException E){
        E.getStackTrace();
    }
    DisplaySong.getDialogPane().getButtonTypes().add(ButtonType.CLOSE);
    Optional<ButtonType> result = DisplaySong.showAndWait();
    if(result.isPresent()) {
        DisplaySongs controller = fxmlLoader.getController();
        controller.Display(AlbumAvailble.getSelectionModel().getSelectedItem());
    }
}

The Display of Songs controller:

public class DisplaySongs {

    @FXML
    private TableView<Song> Songs ;

    public void Display(Album Alb) {
        Songs.getItems().addAll(Alb.getSongsList());
    }
}

The Song class:

package MusicManiPulation;

import javafx.beans.property.SimpleStringProperty;

import java.time.LocalDate;

public class Song {

    private SimpleStringProperty SongName = new SimpleStringProperty("") ;
    private SimpleStringProperty SongLength = new SimpleStringProperty("");
    private LocalDate ReleasedDay ;

    public Song(String songName, String songLength, LocalDate releasedDay) {
        SongName.set(songName);
        SongLength.set(songLength);
        ReleasedDay = releasedDay;
    }

    public String getSongName() {
        return SongName.get();
    }

    public void setSongName(String songName) {
        SongName.set(songName);
    }

    public String getSongLength() {
        return SongLength.get();
    }

    public void setSongLength(String songLength) {
        SongLength.set(songLength);
    }

    public LocalDate getReleasedDay() {
        return ReleasedDay;
    }

    public void setReleasedDay(LocalDate releasedDay) {
        ReleasedDay = releasedDay;
    }
}

Album class:

package MusicManiPulation;

import java.time.LocalDate;
import java.util.ArrayList;

public class Album {

    private String AlbumNam ;

    ArrayList<Song> SongsList ;

    public Album(String albumNam) {
        AlbumNam = albumNam;
        this.SongsList = new ArrayList<>();
    }

    public boolean addNewSongToAlbum(String SongName , String SongLength , LocalDate ReleadsedDay) {

        boolean song = findSong(SongName);

        if (song) {
            return false;
        }
        SongsList.add(new Song(SongName , SongLength,ReleadsedDay));
        return true;
    }


    public boolean removeSong(String SongName){
        for(Song song :SongsList){
            if(song.getSongName().equalsIgnoreCase(SongName)){
                SongsList.remove(song);
                return true;
            }
        }
        return false;
    }

    private boolean findSong(String SongName){

        for(Song song:SongsList){
            if(song.getSongName().equalsIgnoreCase(SongName)){
                return true;
           }
        }
        return false;
    }

    public String getAlbumNam() {
        return AlbumNam;
    }

    public ArrayList<Song> getSongsList() {
        return SongsList;
    }

    @Override
    public String toString() {
        return AlbumNam;
    }
}

the getSongList method in Album class:

public ArrayList<Song> getSongsList() {
    return SongsList;
}

Every time I press the "Display" Button the Table is Empty

You should ask a specific quesiton, also provide a [minimal complete reproducible code](https://stackoverflow.com/help/minimal-reproducible-example) so we can help you. — Mohamed Benmahdjoub, Jun 26 '19 at 08:43
I suggest this answer : [JavaFX - How to use a method in a controller from another controller?](https://stackoverflow.com/questions/29639881/javafx-how-to-use-a-method-in-a-controller-from-another-controller) — Mohamed Benmahdjoub, Jun 26 '19 at 08:48
Where is `SongsList` populated ? (By the way all names of variables should start with miniscule letter to make your code more readable) — Mohamed Benmahdjoub, Jun 26 '19 at 09:24
It's alright haha :D Where are you filling the `songsList` in the `album` variable — Mohamed Benmahdjoub, Jun 26 '19 at 09:26
Unrelated to your problem: please learn java naming conventions and stick to them. — kleopatra, Jun 26 '19 at 09:29
You know what ? :D Put all your classes and fxml files code. I can't replicate the same example with only what you provided. — Mohamed Benmahdjoub, Jun 26 '19 at 09:32
can i upload them and pass u a link ? it will take forever to copy and past them — TigerTN, Jun 26 '19 at 09:35
And I meant, where do you call that `addnewSongtoAlbum()` method — Mohamed Benmahdjoub, Jun 26 '19 at 09:35
read the help page that @Calips referenced in the first comment and act accordingly (no, don't upload anything anywhere - instead write a small example just for the purpose of demonstrating what you want to achieve and how it doesn't work as you expect) — kleopatra, Jun 26 '19 at 09:38
there you go mate https://drive.google.com/open?id=1lDg31YTC2wmMN4A7sfH9ETkMgjsnKCO4 — TigerTN, Jun 26 '19 at 09:42
@TigerTN Sorry for the late answer! Someone decided to evacuate my floor yesterday -_- Check the answer — Mohamed Benmahdjoub, Jun 27 '19 at 09:45

score 1 · Accepted Answer · answered Jun 27 '19 at 09:44

1

public void Display(){

       Dialog<ButtonType>DisplaySong = new Dialog<>();
        DisplaySong.initOwner(DisplayBorder.getScene().getWindow());
        DisplaySong.setTitle("DisPlay Songs");
        FXMLLoader fxmlLoader = new FXMLLoader();
        fxmlLoader.setLocation(getClass().getResource("DisplaySongs.fxml"));
        try {
            DisplaySong.getDialogPane().setContent(fxmlLoader.load());
        }catch (IOException E){
            E.getStackTrace();
        }
        DisplaySong.getDialogPane().getButtonTypes().add(ButtonType.CLOSE);
        System.out.println("BEFORE Show");
        //Optional<ButtonType> result = DisplaySong.showAndWait(); //removed this line too
        DisplaySong.show();

      // if(result.isPresent()){ REMOVED THIS LINE.
     // YOU FORGOT THE CAST HERE :
         DisplaySongs controller = (DisplaySongs) fxmlLoader.getController(); 
            controller.Display(AlbumAvailble.getSelectionModel().getSelectedItem());

}

answered Jun 27 '19 at 09:44

Mohamed Benmahdjoub

1,270
4
19
38

Thanks Calips i figured it out yesterday as ur solution btw i would love to stay in contact with someone expert in java , coz i m newbie hope to learn more from U thanks again – TigerTN Jun 27 '19 at 09:53
1

I am not an expert XD but glad to help :) – Mohamed Benmahdjoub Jun 27 '19 at 09:57
Thanks again for real ^________^ i've spent almost 7 hours figuring it out yesterday – TigerTN Jun 27 '19 at 10:05
Calips could you check my last issue i mean for real i 've spent two days now resolving it xD – TigerTN Jul 07 '19 at 17:41
https://stackoverflow.com/questions/56920892/how-to-display-my-data-from-file-in-tableview – TigerTN Jul 07 '19 at 17:41

How to Manipulate TableView from another Controller?

1 Answers1