ob_get_contents doesnt work when within foreach

Asked Jun 26 '19 at 01:37

Active Jun 26 '19 at 01:37

Viewed 58 times

Hi,

I have this code which works just fine

function show_aval($place) {
   echo $place;
}

ob_start();
show_aval(london);
$show_aval = ob_get_contents();
ob_clean();

ob_start();
show_aval(york);
$show_aval2 = ob_get_contents();
ob_clean();

ob_start();
show_aval(liverpool);
$show_aval3 = ob_get_contents();
ob_clean();

but I want to simplify this code like this:

$avalrooms = [];
$cities = ["london", "york", "liverpool"];
foreach ($cities as $city) {
    ob_start();
    show_aval($city);
    $avalrooms[$city] = ob_get_contents();
    ob_clean;
}

however, this seems to nullify ob_get_contents because the function is being executed right away as show_aval($city); is stated.

Why is this happening?

Thank you.

asked Jun 26 '19 at 01:37

Cain Nuke

2,843
5
42
65

Typo `ob_clean;`? Also, check out [`ob_get_clean`](https://www.php.net/manual/en/function.ob-get-clean.php), dont need to clean up then. – Lawrence Cherone Jun 26 '19 at 01:39
I dont see any typo in my code. – Cain Nuke Jun 26 '19 at 01:46
1

Sorry, it should be `ob_clean();` https://3v4l.org/rTWg8 – Lawrence Cherone Jun 26 '19 at 01:47
Though why are you using ob_ functions, you should only need them for the most part if you're building a templating system, and want to render in variables html etc, but then you add the ob_ calls inside the function. – Lawrence Cherone Jun 26 '19 at 01:50

ob_get_contents doesnt work when within foreach

0 Answers0