Single Responsibility Principle for Dao Classes

Question

This is a sample code which haven't followed the single responsibility principle,

public class EmailSender
{
  public void SendEmail(string customerID, 
                       string emailNotificationType)
  {
    //STEP1: load customer details
    //STEP2: get email content
    //STEP3: send email (using SmtpClient class)
  }

  public string GetEmailContent(Customer customer, 
                 string emailNotificationType)
   {
    // Build the email notification content
   }
}

I agree, It will create the issue in case If I need to do following,

-> Changes in the way, you are loading customer details.

-> Changes to the email content because of requirement enhancements / changes.

-> If there any change in the way you are sending the email instead of using SmtpClient class or something like that.

so we need to apply Single Responsibility Principle to separate the classes. I totally agree on this principle. Say I need to create three classes like

EmailSender - which only focus on sending email CustomerRepository - which only focus on fetching customer data EmailContentBuilder - which parse the email content

But say If I have a Dao like CustomerDao, As of now I have all the CRUD operations related to CustomerDao in the same class like below

CustomerDao class
- add()
- update() - get()
- getAll()
- update()

Do we need to apply SingleResponsibilityPrinciple here? If so How to apply for CustomerDao class?

Thanks,
Harry

I believe [Software Engineering Stack Exchange](https://softwareengineering.stackexchange.com/) may be more appropriate for your question. — Abra, Jun 25 '19 at 04:12
@abra, IMHO, It is also a programmatic question I believe, Please let me know your thoughts on CustomerDao please — Harry, Jun 25 '19 at 04:16
Check this, It is important to apply the pattern at the right abstraction level. https://softwareengineering.stackexchange.com/questions/155627/something-confusing-about-single-responsibility-principle — arunvg, Jun 25 '19 at 04:50
`CRUD` is good if used in single class and yes you are doing well. Do not delegate to much responsibility to other classes unless you are ready to maintain that level of code base for small operation. And `mail Sender` can be static and can be used as util class :) — bananas, Jun 25 '19 at 04:56

score 0 · Answer 1 · answered Jul 11 '19 at 01:00

You do not want to apply to DAO because it only do one thing.

good example

sourse

Patterns and principles are great things, but used incorrectly they can make a simple problem just as complex as not having them.

SRP shouldn't be understood in a strict manner. One object should have very few responsibilities, not "one". Here CustomerDao is only responsible for Customer persistence, so it has only one responsibility.

Andrey Koshelev · Answer 2 · 2020-11-01T20:25:54.673

Despite its name SRP is expressed as "A class should have only one reason to change". DAO is changed for the single reason: when mapping between database table and business object changes so DAO does not violate SRP.

Think of an example: business logic changes so that we need to add some more data to our object: we add fields to our business object, columns to database table and of course we need to change the mapping. We are likely to change get/add/update methods of our single DAO class then.

For clear understanding of the principle I would recommend reading the original source of SOLID principles: Robert Matin's book Agile Software Development, Principles, Patterns, and Practices.

Single Responsibility Principle for Dao Classes

2 Answers2