Battling with my menu - Why is this broken ? - the
php is printed, not executed?

Question

Im a little new to this, and this one issue is driving me mad..

The tag "?= $active[0] ?" on the

is getting printed rather than executed.

Any pointers appreciated...

$url = $_SERVER['REQUEST_URI'];
$active = 'class=""';

switch($url){

    case('/SSPCorporate/index.php'):
        $active[0] = ' class="active"';
    break;

    case('/SSPCorporate/about.php'):
    case('/SSPCorporate/our-customers.php'):
    case('/SSPCorporate/our-partners.php'):
    case('/SSPCorporate/our-clients.php'):
    case('/SSPCorporate/our-standards.php'):
    case('/SSPCorporate/our-awards.php'):
        $active[1] = ' class="active"';
    break;

    case('/SSPCorporate/solutions.php'):
        $active[2] = ' class="active"';
    break;

    case('/SSPCorporate/services.php'):
        $active[3] = ' class="active"';
    break;

    case('/SSPCorporate/sustainability.php'):
    case('/SSPCorporate/what-are-we-doing.php'):
    case('/SSPCorporate/what-can-you-do.php'):
    case('/SSPCorporate/what-we-support.php'):
    case('/SSPCorporate/references.php'):
        $active[4] = ' class="active"';
    break;

    case('/SSPCorporate/healthcare.php'):
        $active[5] = ' class="active"';
    break;

    case('/SSPCorporate/blog/'):
        $active[6] = ' class="active"';
    break;

    case('/SSPCorporate/contact.php'):
        $active[7] = ' class="active"';
    break;

}

?>

echo($url);

?>

<nav>
  <ul class="clearfix">
    <li id="first" <?= $active[0] ?> <a href="index.php" class="Bold">Home</a></li>
    <li <?= $active[1] ?> <a href="about.php" class="Bold">About</a></li>
    <li <?= $active[2] ?> <a href="solutions.php" class="Bold">Solutions</a></li>
    <li <?= $active[3] ?> <a href="services.php" class="Bold">Services</a></li>
    <li <?= $active[4] ?> <a href="sustainability.php" class="Bold">Sustainability</a></li>
    <li <?= $active[5] ?> <a href="healthcare.php" class="Bold">Healthcare</a></li>
    <li <?= $active[6] ?> <a href="/blog/" class="Bold">Blog</a></li>
    <li id="last" <?= $active[7] ?> <a href="contact.php" class="Bold">Contact</a></li>
  </ul>
</nav>

The problem is the code is printing each letter from the string - not the string as a variable in the html..

score 1 · Answer 1 · answered Apr 13 '11 at 14:36

1

Chances are PHP's short_open_tag directive is disabled.

That's actually a good thing as they lead to less portable code and shouldn't be used.

I would suggest using <?php echo $active[0] ?> instead.

answered Apr 13 '11 at 14:36

David Hancock

14,861
4
41
44

score 0 · Accepted Answer · edited Apr 13 '11 at 14:35

0

Very likely your server is not configured to support short tags <? {code} ?>. Try replacing them with <?php {code} ?>. You could also enable short tags, but it's not recommended.

edited Apr 13 '11 at 14:35

Mat

202,337
40
393
406

answered Apr 13 '11 at 14:34

Bryan Agee

4,924
3
26
42

score 0 · Answer 3 · edited May 23 '17 at 11:47

0

Check the PHP directive short_open_tag. If it probably off, which is the cause of the stuff beign not executed.

However, it's no good to use them at all, and replacing with <?php would be better of a solution

edited May 23 '17 at 11:47

Community

1
1

answered Apr 13 '11 at 14:35

Fluffy

27,504
41
151
234

Ok, great, fixed the short-tag syntax. But now nothing is printed to the
... ?

swinhoe

Apr 13 '11 at 14:41

Hmmm now what i thought was a variable is being split and printed as an array.. ? Each letter of 'class=""' is being printed in each

.. have i defined $active wrongly ?

– swinhoe Apr 13 '11 at 14:50

score 0 · Answer 4 · answered Apr 13 '11 at 14:37

0

Taking a wild stab,

<li <? echo $active[1]..

would work, as short tags are probably not enabled on your server's php configuration.

answered Apr 13 '11 at 14:37

trickwallett

2,418
16
15

Battling with my menu - Why is this broken ? - the php is printed, not executed?

4 Answers4

Battling with my menu - Why is this broken ? - the
php is printed, not executed?