data must be a string and salt must either be a salt string or a number of rounds

Question

This is the error I am getting: Error: data must be a string and salt must either be a salt string or a number of rounds. This is the code that i have written is for resetting the password in my db using their email id. If this is not correct can anyone tell me how to reset the password in node js using oracle database. The error is in the bcrypt.hash line.

Below is the whole code:

function changePassword(email, newPassword, callback) {

    var oracledb = require('oracledb');
    oracledb.outFormat = oracledb.OBJECT;

    oracledb.getConnection({
        user          : '',
        password      : '',
        connectString : ''
      },
      function(err, connection) {
        if (err) {
          return callback(new Error(err));
        }
        bcrypt.hash(newPassword, numSaltRounds, function(err, hash) {
          if (err) { return callback(err); }
          connection.execute(
            ' select password as "password" = : hash, ' +
            ' from jsao_users ' +
            ' where email = :email ', [hash, email], { autoCommit: true },
            function(err, result) {
              if (err) {
                console.log(err);
                doRelease(connection);
                return callback(new Error(err));
              }
              doRelease(connection);
              callback(null, result.rowsAffected > 0);
            });
        });

        // Note: connections should always be released when not needed
        function doRelease(connection) {
          connection.close(
            function(err) {
              if (err) {
                console.error(err.message);
              }
            });
        }
      });
}

And this is the part where I am getting the error:

 bcrypt.hash(newPassword, numSaltRounds, function(err, hash) { //this is the line
          if (err) { return callback(err); }
          connection.execute(
            ' select password as "password" = : hash, ' +
            ' from jsao_users ' +
            ' where email = :email ', [hash, email], { autoCommit: true },
            function(err, result) {
              if (err) {
                console.log(err);
                doRelease(connection);
                return callback(new Error(err));
              }
              doRelease(connection);
              callback(null, result.rowsAffected > 0);
            });
        });

better to check first if newPassword and numSaltRound are falsy — Aljohn Yamaro, Dec 06 '19 at 03:08

score 3 · Answer 1 · answered Oct 28 '20 at 08:15

This error is getting while you pass the newPassword as number. So, better to pass the newPassword as string or you can convert the newPassword to string like newPassword.toString().

Example.

  let newPassword = newPassword.toString();

  bcrypt.hash(newPassword, numSaltRounds, function(err, hash) {});

score 2 · Answer 2 · answered Dec 25 '22 at 06:39

2

I'm also getting this error. i tried this way## Heading ##.

we have send the values in integer. So this is throw error { "email": "vignesh@gmail.com", "password": 1234 // this is integer }

So, I've modified integer to String then error was gone { "email": "vignesh@gmail.com", "password": "1234" // this is String }

Conclusion: this is expect the String values.

answered Dec 25 '22 at 06:39

Mukesh Khan

21
1

Your answer could be improved with additional supporting information. Please [edit] to add further details, such as citations or documentation, so that others can confirm that your answer is correct. You can find more information on how to write good answers [in the help center](/help/how-to-answer). – Community Dec 26 '22 at 07:49

score 1 · Answer 3 · answered Jun 18 '22 at 14:54

1

I had set my password as Number type in my user model. Hash function expects a string as first argument. Setting the type to String helped.

answered Jun 18 '22 at 14:54

Himanshu Shukla

31
1

score 1 · Answer 4 · answered Mar 16 '23 at 16:17

1

You are probably sending a number for password

{
  "email": "yourEmail@mail.com",
  "fullName": "Fullname",
  "password": "123456" // make sure it is a string
}

answered Mar 16 '23 at 16:17

Ismoil Shokirov

2,213
2
16
32

score 0 · Answer 5 · edited Oct 12 '22 at 16:02

0

Please make your plaintext or req password into string before encripting.

plaintext = req.body.password.toString();
const hashPassword = await bcrypt.hash(plaintext, salt);

edited Oct 12 '22 at 16:02

Tyler2P

2,324
26
22
31

answered Oct 08 '22 at 16:29

Sm AL-Amin

1

score 0 · Answer 6 · answered Feb 17 '23 at 20:29

0

When you are setting the password specifically hashing the password, be consistent, when using bcrypt/bcrypt.js either use the hashSync without the async/await key word or use the hash with the async/await keyword.

answered Feb 17 '23 at 20:29

Arnold Omondi

29
3

score 0 · Answer 7 · answered Mar 31 '23 at 22:11

The same error was happening to me, the problem is that in the definition of my model I put the type of my password as Number, for this reason brcypt returned the error, when i changed it to type String, it worked normally.

I was using Mongo db Atlas.

data must be a string and salt must either be a salt string or a number of rounds

7 Answers7