how to iterate over a queryset in django as i get 'int' object is not iterable

Question

I want to get the object from a queryset

 accounts = group.get_external_accounts(include_sub_groups=True)

    try:
        account: StripeExternalAccount = accounts.get(account_id)
    except StripeExternalAccount.DoesNotExist:
        return Response(status=status.HTTP_400_BAD_REQUEST)

I have tried this. it works fine but i want to do it through try except

   account: StripeExternalAccount = None
        for acc in accounts:
             if acc.id == int(account_id):
                account = acc
                break
        if not account:
            return Response(status=status.HTTP_400_BAD_REQUEST)

What is `get_external_accounts ` and `get` ? Kindly provide relevant piece of code. — Umair Mohammad, May 23 '19 at 07:10
get_external_accounts is model method to get the queryset and i get — deve_mo, May 23 '19 at 07:12
Hard to devise solution without context, anyways try `accounts = group.get_external_accounts(include_sub_groups=True).values_list('id', flat=True)[3]` — Umair Mohammad, May 23 '19 at 07:49

Daniel Hepper · Accepted Answer · 2019-05-23T09:24:43.017

0

As its name implies, .values_list() returns a list of values and a list object doesn't have a .get() method. If get_external_accounts returns a queryset, you can simply use the .get() on the queryset:

accounts = group.get_external_accounts(include_sub_groups=True)

try:
    account: StripeExternalAccount = accounts.get(id=account_id)
except StripeExternalAccount.DoesNotExist:
    return Response(status=status.HTTP_400_BAD_REQUEST)

If you need the list of account IDs later in your code, you could add:

account_ids = accounts.values_list('id')

It might be worth pointing out that getting a single item with accounts.get() and getting the list of all IDs with accounts.values_list('id') will perform two queries to your database.

If you have multiple accounts with the same id and want to get the first one, use

account: StripeExternalAccount = accounts.filter(id=account_id).first()

edited May 23 '19 at 09:24

answered May 23 '19 at 08:11

Daniel Hepper

28,981
10
72
75

Did you use `accounts.get()` or `accounts.get(id=account_id)`? – Daniel Hepper May 23 '19 at 08:58
i used accounts.get(id=account_id) – deve_mo May 23 '19 at 09:01
and when i use account: StripeExternalAccount = accounts.get(account_id) it gives 'int' object is not iterable – deve_mo May 23 '19 at 09:22
I updated my answer. If this does not solve your problem. Please edit your question and add the code you now have – Daniel Hepper May 23 '19 at 09:25
it worked but i dont have multiple accounts with same id – deve_mo May 23 '19 at 09:28
this was the queryset for accounts.values_list('id') – deve_mo May 23 '19 at 09:30
and my account_id was 36 – deve_mo May 23 '19 at 09:31
then `accounts.get(id=account_id)` should not raise `MultipleObjectsReturned` – Daniel Hepper May 23 '19 at 09:32
but i have checked the database id is the pk and it is different for all – deve_mo May 23 '19 at 09:35
when we use accounts.filter(id=account_id) it gives 'QuerySet' object has no attribute '_meta' @daniel – deve_mo Jun 11 '19 at 12:16

how to iterate over a queryset in django as i get 'int' object is not iterable

1 Answers1