Function parameter - id vs object

Question

I have some service that return user's data by it's id. User already stored in request(session) - no need to fetch it every time.

The question is what is the best practice for parameter. Id of the user(SOLID) or user object(more validation/typings).

Example:

//...

// this
public async getByUser(user: User) {
  return await Transaction.findAll({
    where: { userId: user.id }
  });
}

// or this
public async getByUser(userId: number) {
  return await Transaction.findAll({
    where: { userId }
  });
}

Methods should only do what they are supposed to do. If it gets a user by ID, the only parameter provided should be an ID. — Oliver, Apr 23 '19 at 12:45

score 2 · Accepted Answer · answered Apr 23 '19 at 11:45

Either. Really. Just keep the naming proper.

The more declarative your function names, the less confusion

//...

// this
public async getByUser(user: User) {
  return await Transaction.findAll({
    where: { userId: user.id }
  });
}

// or this
public async getByUserId(userId: number) {
  return await Transaction.findAll({
    where: { userId }
  });
}

Function parameter - id vs object

1 Answers1