How i can use different url with same method in Controller With @GetMapping?

Question

it unable to run on both URL

@GetMapping(value= {"/durationtrend/{moduleId}","/durationtrend/{moduleId}/{records}"},produces=MediaType.APPLICATION_JSON_VALUE)
public List<ExecutionDurationResource> getExecutionDurationByModuleId(@PathVariable("moduleId") Integer moduleId,@PathVariable("records") Integer records) {    
    return executionDurationService.getExecutionDuration(moduleId,records); 
}

http://localhost:8080/seleniumexecutiontrending/reports/durationtrend/427 -->it not Call. http://localhost:8080/seleniumexecutiontrending/reports/durationtrend/427/7-->it executes.

I want to execute both in same method

score 0 · Answer 1 · answered Mar 30 '19 at 02:07

 @GetMapping(value= {"/durationtrend/{moduleId}","/durationtrend/{moduleId}/{records}"},produces= MediaType.APPLICATION_JSON_VALUE)
public List getExecutionDurationByModuleId(HttpServletRequest request) {
    Map map= (Map) request.getAttribute(HandlerMapping.URI_TEMPLATE_VARIABLES_ATTRIBUTE);
    Integer moduleId=null,records=null;
    if(map!=null && map.get("moduleId")!=null){
        moduleId = Integer.valueOf(map.get("moduleId").toString());
    }
    if(map!=null && map.get("records")!=null){
        records = Integer.valueOf(map.get("records").toString());
    }
    System.out.println("moduleId:"+moduleId);
    System.out.println("records:"+records);
    //then you use modules and records , just judge  whether they are null?
    return executionDurationService.getExecutionDuration(moduleId,records);
}

I tried code above that works . Try it , hopes that help you !

score 0 · Answer 2 · answered Mar 30 '19 at 16:57

here your problem is

@PathVariable("moduleId") Integer moduleId,@PathVariable("records") Integer records

you need moduleId and records parameters for both your URL, in the first URL "/durationtrend/{moduleId}" you did not have records parameter that's why you have

org.springframework.web.servlet.handler.AbstractHandlerExceptionResolver.resolveException Resolved [org.springframework.web.bind.MissingPathVariableException: Missing URI template variable 'records' for method parameter of type Integer]

this error

Actually, you can achieve this goal in many ways, like using HttpServletRequest and other things, but remember you are using spring and you need to simplify the things using spring framework.

the simple way which I suggest is using two separate controllers and simplify the things.

@GetMapping("/durationtrend/{moduleId}")
public void getExecutionDurationByModuleId(@PathVariable("moduleId") Integer moduleId) {
    return executionDurationService.getExecutionDuration(moduleId);
    System.out.println(moduleId);
}

@GetMapping("/durationtrend/{moduleId}/{records}")
public void getExecutionDurationByRecords(@PathVariable("moduleId") Integer moduleId, @PathVariable("records") Integer records) {
    return executionDurationService.getExecutionDuration(moduleId, records);
    System.out.println(moduleId);
    System.out.println(records);
}

this is easy to understand and you can create getExecutionDuration(moduleId) method in your service class and can easily bypass it...

hope it is helpful...

here the System.out.println statements for testing purpose... it worked me — majurageerthan, Mar 30 '19 at 17:00

score 0 · Accepted Answer · edited Apr 01 '19 at 12:47

0

@GetMapping(value= "/module-execution-trend",produces=MediaType.APPLICATION_JSON_VALUE) 
     public List<ExecutionResource> getExecutionResult(@RequestParam("moduleId") Integer moduleId,@RequestParam(name="records",required=false,defaultValue="10")  Integer records ) 
     {
        System.out.println(moduleId); 
        System.out.println(records); 
         return executionService.getModuleExecutionResult(moduleId,records);
     }

edited Apr 01 '19 at 12:47

Vladimir

612
3
16

answered Apr 01 '19 at 08:21

Spacewalker_vir

1
3

I think it's better one – Spacewalker_vir Apr 01 '19 at 08:23

How i can use different url with same method in Controller With @GetMapping?

3 Answers3