How to return results of a query? Mysql nodejs

Question

I am using mysql package from https://www.npmjs.com/package/mysql

So basically I have this function in a file:

module.exports.listGames = (id) => {
  let query = 'SELECT * FROM test';
  if (id) {
    query += 'WHERE userid = ' + connection.escape(id);
  }

  connection.query(query, function(err, results) {
    if (err) {
      throw err;
    }
    console.log(results);
  });
}

and I want to return those results in the json format

so I can call it in another file which is this function:

function sendGames(req, res) {
    const games = db.listGames(req.query.game);
    res.json(games);
}

so my question is, How can I return the results from that query?

score 2 · Answer 1 · answered Mar 28 '19 at 00:39

2

You can either

Use callback

module.exports.listGames = (id, cb) => {
  let query = 'SELECT * FROM test';
  if (id) {
    query += 'WHERE userid = ' + connection.escape(id);
  }

  connection.query(query, function(err, results) {
    if (err) {
      throw err;
    }
    cb(results);
  });
}

module.exports.listGames(12, (results) => {
console.log(results);
})

Use promise

module.exports.listGames = (id) => {
  let query = 'SELECT * FROM test';
  if (id) {
    query += 'WHERE userid = ' + connection.escape(id);
  }
  return new Promise((resolve, reject) => {
    connection.query(query, function(err, results) {
      if (err) {
        throw err;
      }
      resolve(results);
    });
  })

}

module.exports.listGames(12).then(results => console.log(results)

You can encode the response from mysql query to JSON using JSON.stringify.

answered Mar 28 '19 at 00:39

Daniel Jee

664
5
10

1

Using callback throws me an error saying "callback is not a function", using promise it returns me an empty object. I do not need this line "module.exports.listGames(12).then(results => console.log(results)" as I wanna call the function with a req.query in other file and the console.log(results) was only for debugging purposes. Thank you for your help anyway. – Mar 28 '19 at 00:54
@Nicekor the line ```module.exports.listGames(12).then(results => console.log(results)``` is demonstration of how to use listGames function returning a promise object. You can export listGames function and client code can use the function the same way by calling .then(). Also with callback, did you make sure to pass in a correct function? – Daniel Jee Mar 28 '19 at 01:58

Riajul Islam · Answer 2 · 2019-03-28T07:02:38.310

module.exports.listGames = (id) => {
  let query = 'SELECT * FROM test';
  if (id) {
    query += 'WHERE userid = ' + connection.escape(id);
  }

  connection.query(query, function(err, results) {
    if (err) {
      throw err;
    }
    return (results);
  });
}

Declare javascript async function and call the method from here.

async function  sendGames (req, res) {
    var games = await db.listGames(req.query.game);
    res.json(games);
}

How to return results of a query? Mysql nodejs

2 Answers2