RxSwfit bind operation retain cycle

Question

I am new at rxswift framework.I have written a code below and I am not sure.Is there any retain cycle? Must I use weak reference to self?

    loginButton.rx.tap.bind {
        print(self.nameText.value ??  "")
       self.nameText.accept("ahmet vefa saruhan")
    }.disposed(by: disposebag)

second case is :

func myTestFunction(handler : () -> Void) {
    handler()
}

myTestFunction {
        self.isVisible = false
    }

is here any retain cycle problem?

Khoren Markosyan · Accepted Answer · 2019-03-12T15:02:31.563

3

Yes, weak should be used when you using self inside block. And use subscribe instead of bind.

basicLoginButton.rx.tap.subscribe(onNext: { [weak self] () in
    print(self?.nameText.value ?? "")
    self?.nameText.accept("ahmet vefa saruhan")
}).disposed(by: disposeBag)

I think in the second case, everything is correct, there is not needed 'weak'.

edited Mar 12 '19 at 15:02

answered Mar 12 '19 at 14:49

Khoren Markosyan

208
1
2
7

thanks for your answer. I have edited the question with part 2 :) in second example , weak should be used? – ahmetvefa53 Mar 12 '19 at 14:55
also why I must subcribe it? it is same functionality – ahmetvefa53 Mar 12 '19 at 15:46
Thank you . I got it. İf closure stored in a variable, there is a retained cycle. – ahmetvefa53 Mar 12 '19 at 16:26

RxSwfit bind operation retain cycle

1 Answers1