Download a file with an AsyncTask

Question

I tried using many codes I've found for downloading files with an AsyncTask with no success yet. I get an error on the logcat: E/Error:: No such file or directory. Despite looking for solutions for this error, couldn't find What's missing or wrong.

This is the doInBackground method in which I assume something is missing/wrong:

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_splash);

    new DownloadJSON().execute("http://api.androidhive.info/json/movies.json");
}

protected String doInBackground(String...fileUrl) {
        int count;
        try {
            String root = "data/data/com.example.jsonapp2";

            URL url = new URL(fileUrl[0]);

            URLConnection connection = url.openConnection();
            connection.connect();

            // input stream to read file - with 8k buffer
            InputStream input = new BufferedInputStream(url.openStream(), 8192);

            File fileName = new File(root+"/movies.json");
            boolean existsOrNot = fileName.createNewFile(); // if file already exists will do nothing

            // Output stream to write file

            OutputStream output = new FileOutputStream(fileName,false);
            byte data[] = new byte[1024];

            System.out.println("Downloading");
            long total = 0;
            while ((count = input.read(data)) != -1) {
            total += count;

            // writing data to file
            output.write(data, 0, count);
        }
            // flushing output
            output.flush();
            // closing streams
            output.close();
            input.close();
        } catch (Exception e) {
            Log.e("Error: ", e.getMessage());
        }
        return null;
    }

Thanks.

Didn't want to bombard with redundant code. If some other code is needed, I'd love to provide it.

Answer 1

Your root is wrong

String root = "data/data/package.appname";

make sure your root contains right package name or file path.

package name which should be your application id

Answer 2

UPDATED ANSWER

this is working for me, write file in local storage and read it again on method PostExecute

class DownloadJSON extends AsyncTask<String, Void, Void>{

        String fileName;
        String responseTxt;
        String inputLine;
        String folder;

        @Override
        protected Void doInBackground(String... strings) {
            try {
                String root = "data/data/com.example.jsonapp2";
                URL url = new URL(strings[0]);
                HttpURLConnection urlConnection = (HttpURLConnection)url.openConnection();
                //Set methods and timeouts
                urlConnection.setRequestMethod("GET");
                urlConnection.setReadTimeout(15000);
                urlConnection.setConnectTimeout(15000);

                urlConnection.connect();

                //Create a new InputStreamReader
                InputStreamReader streamReader = new
                        InputStreamReader(urlConnection.getInputStream());
                BufferedReader reader = new BufferedReader(streamReader);

                StringBuilder response  = new StringBuilder();

                //Check if the line we are reading is not null
                while((inputLine = reader.readLine()) != null){
                    response.append(inputLine);
                }

                //Close our InputStream and Buffered reader
                reader.close();
                streamReader.close();

                responseTxt = response.toString();

                Log.d(TAG, "doInBackground: responseText " + responseTxt);

                // PREPARE FOR WRITE FILE TO DEVICE DIRECTORY
                FileOutputStream fos = null;
                fileName = "fileName.json";
                folder = fileFolderDirectory();

                try {
                    fos = new FileOutputStream(new File(folder + fileName));
                    //fos = openFileOutput(folder + fileName, MODE_PRIVATE);
                    fos.write(responseTxt.getBytes());
                } catch (IOException e) {
                    e.printStackTrace();
                } finally {
                    if(fos != null){
                        fos.close();
                    }
                }


            } catch (Exception e) {
                Log.e("Error: ", e.getMessage());
            }
            return null;
        }

        @Override
        protected void onPostExecute(Void aVoid) {
            super.onPostExecute(aVoid);

            // -- THIS METHOD IS USED TO ENSURE YOUR FILE AVAILABLE INSIDE LOCAL DIRECTORY -- //

            FileInputStream fis = null;
            try {
                fis = new FileInputStream(new File(folder +fileName));
                InputStreamReader isr = new InputStreamReader(fis);
                BufferedReader br = new BufferedReader(isr);
                StringBuilder sb = new StringBuilder();
                String text;

                while ((text = br.readLine()) != null) {
                    sb.append(text).append("\n");
                }

                Toast.makeText(TestActivity.this, "result " + sb.toString(), Toast.LENGTH_SHORT).show();

            } catch (IOException e) {
                e.printStackTrace();
            }finally {
                try {
                    fis.close();
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        }
    }

ops, almost forget this method

public static String fileFolderDirectory() {
        String folder = Environment.getExternalStorageDirectory() + File.separator + "write_your_app_name" + File.separator;
        File directory = new File(folder);
        if(!directory.exists()){
            directory.mkdirs();
        }
        return folder;
    }