Suppressing Java Findbugs error (EI_EXPOSE_REP)

Question

I have a Java gettor method that looks like the following:

import java.util.Date;
//...
public Date getSomeDate() {
  return someDate;
}

and Findbugs reports that this exposes a mutable object: "May expose internal representation by returning reference to mutable object". I changed the code to this:

import java.util.Date;
//...
public Date getSomeDate() {
  return new Date(someDate.getTime());
}

but Findbug still reports the same vulnerability. What more can I do to suppress/fix this problem? I am running Findbugs 1.3.9 in the IntellJ 10 Findbugs plugin.

score 11 · Accepted Answer · answered Mar 29 '11 at 12:16

11

I just realized that Findbugs analyzes compiled code (.class files), not source code. After rebuilding and re-running Findbugs, the problem went away.

answered Mar 29 '11 at 12:16

Ralph

31,584
38
145
282

I've been the victim of the same situation :) - spending 15 minutes wondering why my change didn't fix the error, and then realizing that I didn't rebuild. – Rob Hruska Mar 29 '11 at 14:21
@Rob Hruska: Took me about the same amount of time :-). – Ralph Mar 29 '11 at 15:00

score 0 · Answer 2 · edited Mar 13 '19 at 12:33

0

No,we need to clone that object using below code :

public Date getSomeDate() {
  return new Date(someDate.getTime()).clone();
}

edited Mar 13 '19 at 12:33

ngCoder

2,095
1
13
22

answered Mar 18 '13 at 10:15

Jignesh Vachhani

35
2

Using `new Date` *and* `clone` is too much xD – SebastianH May 25 '16 at 07:56

Suppressing Java Findbugs error (EI_EXPOSE_REP)

2 Answers2

Linked