Java stream and filtering to a Map producing an error

Question

I am trying to use Java streams to create a map which contains the currency code and a string description. The code works when I try to add items 1 to 6, but when I try to add item7 (where the currencyCode param is not initialized), I get the following error.

Exception in thread "main" java.lang.NullPointerException
    at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
    at java.util.concurrent.ConcurrentHashMap$KeySetView.add(ConcurrentHashMap.java:4595)
    at Test.lambda$6(Test.java:73)

How can I modify the below code to filter out items where the currencyCode value is not initialized? I had thought that filtering out null's should do the trick, but that doesn't quite work.

public class Test {

    public static void main(String[] args) {
        Currency item1 = new Currency();
        item1.setCurrencyCode("USD");
        Currency item2 = new Currency();
        item2.setCurrencyCode("GBP");
        Currency item3 = new Currency();
        item3.setCurrencyCode("GBP");
        Currency item4 = new Currency();
        item4.setCurrencyCode("AUS");
        Currency item5 = new Currency();
        item5.setCurrencyCode("USD");
        Currency item6 = new Currency();
        item6.setCurrencyCode("");
        Currency item7 = new Currency();

        List<Currency> list = new ArrayList<>();
        list.add(item1);
        list.add(item2);
        list.add(item3);
        list.add(item4);
        list.add(item5);
        list.add(item6);
        list.add(item7);

        Map<String, String> distinctCurrencyCodes = list.stream()
                .filter( distinctByKey(p -> p.getCurrencyCode()) )
                .filter(p -> (!StringUtils.equals(p.getCurrencyCode(), "USD")))
                .filter(p -> p.getCurrencyCode() != "" || p.getCurrencyCode() != null)
                .map(p -> p.getCurrencyCode() )
                .collect( Collectors.toMap(p -> p, p -> "Blah") );

        for (Map.Entry<String, String> entry : distinctCurrencyCodes.entrySet()) {
            System.out.println(entry.getKey() + "/" + entry.getValue());
        }
    }

    public static <T> Predicate<T> distinctByKey(Function<? super T, ?> keyExtractor) {
        Set<Object> seen = ConcurrentHashMap.newKeySet();
        return t -> seen.add(keyExtractor.apply(t));
    }
}

The "error" that you posted isn't an *error*, it's just an element of the stacktrace that doesn't provide us with any information. — Jacob G., Feb 05 '19 at 19:20
Another issue that I spotted: `p.getCurrencyCode() != ""` - See: https://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java — Jacob G., Feb 05 '19 at 19:25
*"How can I modify the below code to filter out items where the currencyCode value is not initialized?"* Add `.filter( p -> p.getCurrencyCode() != null )` *before* the `.filter( distinctByKey(p -> p.getCurrencyCode()) )` — Andreas, Feb 05 '19 at 19:25
Thank you Andreas! You were right, the ordering on the filtering was the issue for me. — user2254180, Feb 05 '19 at 19:32

score 1 · Answer 1 · answered Feb 06 '19 at 04:34

Problem is in distinctByKey() method actually.

When you are sending a null to add in Set then exception happening. Just change your distinctByKey() method to this. I handled null in this method.

public static <T> Predicate<T> distinctByKey(Function<? super T, ?> keyExtractor) {
    Set<Object> seen = ConcurrentHashMap.newKeySet();
    return t -> {
        Object currencyName = keyExtractor.apply(t);
        if(currencyName == null)
            return false;
        return seen.add(currencyName);
    };
}

If you do like this you do not need to add this filter any more:

.filter(p -> p.getCurrencyCode() != "" && p.getCurrencyCode() != null)

You can remove this. So your filtered portion will be:

Map<String, String> distinctCurrencyCodes = list.stream()
            .filter(distinctByKey(p -> p.getCurrencyCode()))
            .filter(p -> (!StringUtils.equals(p.getCurrencyCode(), "USD")))
            .map(p -> p.getCurrencyCode() )
            .collect( Collectors.toMap(p -> p, p -> "Blah") );

score 0 · Answer 2 · answered Feb 05 '19 at 19:25

0

Your filter to avoid null is wrong, should be &&.

The 7th currency with null value is going through (because null != "") and breaking because null can't be a key on a map.

Try

.filter(p -> p.getCurrencyCode() != "" && p.getCurrencyCode() != null)

answered Feb 05 '19 at 19:25

Lundberg

404
3
4

"and breaking because null can't be a key on a map" - It can for `HashMap` – Jacob G. Feb 05 '19 at 19:28

Java stream and filtering to a Map producing an error

2 Answers2