Test two conditions with shouldly

Question

I have a property in a class

public class User {
    public string FiscalCode {get; set;}
}

And i want test the property fiscal code with two condition. The test is ok if fiscalcode is null or fiscalcode is verified by a method

public bool FiscalCodeIsCorrect(string fiscalcode) 
{
    ....
}

How can i test in a single line with shouldly if one of the two conditions is verified ?

I want use this condition in a test project so the line of code could be

user.FiscalCode.ShouldBeOneOf()

But i can't because null and string are two different types.

`if(FiscalCode == null || FiscalClodeIsCorrect(FiscalCode)`? Assuming the method is defined on `User`. — MakePeaceGreatAgain, Feb 05 '19 at 11:14
i want use shouldly, so i'm looking for a line of code such as user.FiscalCode.ShouldBeOneOf(...) — user3401335, Feb 05 '19 at 11:16
And what´s the problem on having an `||`, which is what you should use obviously? — MakePeaceGreatAgain, Feb 05 '19 at 11:21

shingo · Accepted Answer · 2019-02-05T14:00:10.793

7

ShouldBeOneOf can not deal an function, so I think the simple way is using ShouldBeTrue

(FiscalCode == null || FiscalClodeIsCorrect(FiscalCode)).ShouldBeTrue();

edited Feb 05 '19 at 14:00

answered Feb 05 '19 at 11:29

shingo

18,436
5
23
42

shingo likes shouldly :) – M.kazem Akhgary Feb 05 '19 at 11:50

score 2 · Answer 2 · answered Feb 05 '19 at 11:15

2

I think you can just use basic ||:

if ( FiscalCode == null || FiscalCodeIsCorrect(FiscalCode) )
{
   //something
}

|| is logical OR operator. This evaluates to true in case at least one of the operands evaluates to true. Also, note that it does short-circuiting which means if the FiscalCode is null it will not call FiscalCodeIsCorrect at all.

answered Feb 05 '19 at 11:15

Martin Zikmund

38,440
7
70
91

"so i'm looking for a line of code such as user.FiscalCode.ShouldBeOneOf(...) " – MakePeaceGreatAgain Feb 05 '19 at 11:20

score 0 · Answer 3 · answered Feb 05 '19 at 11:22

what @Martin Zikmund sugessted is right too but in your case both Null and FiscalCodeIsCorrect should be ok. So putting the null validation logic in FiscalCodeIsCorrect should be a better solution, then you wont have to validate if null every time. so here is what i mean

public bool FiscalCodeIsCorrect(string fiscalcode) 
{
    if (fiscalcode == null)
       return true;
    //....You code here
}

now you only have to chack

if (FiscalCodeIsCorrect(FiscalCode) )
{
   //something
}

Test two conditions with shouldly

3 Answers3