Conditional IF Exists Insert

Question

I have a query to first check if something exists. If yes, insert something into a table variable. Otherwise, insert something else into the same table variable.

IF NOT EXISTS (SELECT 1 FROM @Main WHERE CustomerId = @CustomerId)
(   
    BEGIN  
        INSERT INTO @Result 
            SELECT .... 
            FROM ... 
            WHERE...
   END
)
ELSE
   INSERT INTO @Result  
       SELECT .... 
       FROM ...  
       WHERE...

For some reason I keep getting the errors below complaining inside the NOT EXISTS condition... The ELSE part is completely fine.

Incorrect syntax near the keyword 'BEGIN'
Incorrect syntax near ')'
Incorrect syntax near '@Result'

Where did I do wrong?

What database are you using? – Gordon Linoff Jan 31 '19 at 01:30 — Gordon Linoff, Jan 31 '19 at 01:30

score 4 · Accepted Answer · answered Jan 31 '19 at 01:36

The parentheses don't belong around the BEGIN/END:

IF NOT EXISTS (SELECT 1 FROM @Main WHERE CustomerId = @CustomerId)   
BEGIN  
    INSERT INTO @Result 
        SELECT .... FROM ... WHERE...
END
ELSE . . .

I would also suggest that you list the columns for @Result for the INSERT. This can prevent future problems.

score 2 · Answer 2 · answered Jan 31 '19 at 01:33

2

try this

IF NOT EXISTS (SELECT 1 FROM @Main WHERE CustomerId = @CustomerId)

     BEGIN  
          INSERT INTO @Result 
          SELECT .... FROM ... WHERE...
     END

ELSE

     BEGIN
          INSERT INTO @Result 
          SELECT .... FROM ... WHERE...
     END

answered Jan 31 '19 at 01:33

asmgx

7,328
15
82
143

Yes removing the parentheses helps! – ichachan Jan 31 '19 at 01:38

Conditional IF Exists Insert

2 Answers2