I am doing unit testing with Jasmin and Istanbul.
I try to do unit testing on the following method:
getDiploma(spinnerMessage: string): Observable<DiplomaModel> {
const diploma = this.diplomasState.diploma;
if (diploma) {
// Return diploma info from store
return observableOf(diploma);
} else {
// Get and return diploma info from backend
return this.http.get<DiplomaModel>(this.apiDiploma, spinnerMessage).pipe(map((result) => {
return this.setDiplomasInStore(result);
}));
}
}
And my unit test looks like this:
it('It should return diploma from the backend when snapshot exist ', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
// tslint:disable-next-line:no-commented-code
/* const response = [{ mock: 'mock' } as any];
diplomaService['getDiplomaSnapshot'] = response;
diplomaService.getDiplomaState().subscribe(i => {
expect(i).toEqual(response);
}); */
});
it('It should return diploma if snapshot doenst exist', () => {
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
const spyDocument = spyOn(diplomaService, 'getDiploma').and.callThrough();
diplomaStoreServiceMock.returnState({});
const response = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(response, 200);
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
afwHttp.returnOnlyResponse();
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
expect(spyDocument).toHaveBeenCalledWith('spinnerText');
});
But in Istanbul I get still a red line on this line:
return observableOf(diploma);
with a I and if I hover over the I is says:
if Path not taken.
So how to solve this?
Thank you.
but that is why I have two methods. But you mean this method:
it('It should return diploma from the backend when snapshot exist ', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
What I have to change about this test method?
You mean like this:
it('It should return diploma from the backend when snapshot exist ', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
diplomaService.getDiploma('spinnerText');
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
I also tried like this:
it('It should return diploma from the backend when snapshot exist ', () => {
const response = [{ mock: 'mock' } as any];
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
diplomaService.getDiploma('spinnerText').subscribe( i => {
expect(i).toEqual(response);
});
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
And if I add this method:
it('It should return diploma', () => {
const response = [{ mock: 'mock' } as any];
diplomaService.getDiploma('spinnerText').subscribe( i => {
expect(i).toEqual(response);
});
});
I get this error:
ERROR in apps/register/src/app/shared/services/src/diploma.service.spec.ts(67,31): error TS2345: Argument of type 'any[]' is not assignable to parameter of type 'Expected'. Type 'any[]' is not assignable to type 'ObjectContaining'. Property 'jasmineMatches' is missing in type 'any[]'.
So I have now three methods:
it('It should return diploma from the backend when snapshot exist ', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
it('It should return diploma', () => {
const response = [{ mock: 'mock' } as any];
diplomaService.getDiploma('spinnerText').subscribe( i => {
expect(i).toEqual(response);
});
});
it('It should return diploma if snapshot doenst exist', () => {
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
const spyDocument = spyOn(diplomaService, 'getDiploma').and.callThrough();
const response = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(response, 200);
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
afwHttp.returnOnlyResponse();
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
expect(spyDocument).toHaveBeenCalledWith('spinnerText');
});
This is the hole test file:
describe('Services: DiplomaService', () => {
let afwHttp: AfwHttpMock;
let diplomaService: DiplomaService;
let diplomaStoreServiceMock: DiplomaStoreServiceMock;
let feedbackStoreServiceMock: FeedbackStoreServiceMock;
let multiFileUploadServiceMock: MultiFileUploadServiceMock;
beforeEach(() => {
afwHttp = new AfwHttpMock();
diplomaStoreServiceMock = new DiplomaStoreServiceMock();
multiFileUploadServiceMock = new MultiFileUploadServiceMock();
feedbackStoreServiceMock = new FeedbackStoreServiceMock();
diplomaService = new DiplomaService(afwHttp as any,
diplomaStoreServiceMock as any,
feedbackStoreServiceMock as any,
multiFileUploadServiceMock as any);
});
it('should create an instance', () => {
expect(diplomaService).toBeTruthy();
});
it('It should return diplomadocumentList', () => {
// tslint:disable-next-line:no-duplicate-string
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
const spyDocumentList = spyOn(diplomaService, 'getDiplomaDocumentList').and.callThrough();
const response = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(response, 200);
const result2 = diplomaService.getDiplomaDocumentList('spinnerText');
result2.subscribe(() => {
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
expect(spyDocumentList).toHaveBeenCalledWith('spinnerText');
});
afwHttp.returnOnlyResponse();
});
// tslint:disable-next-line:no-commented-code
it('It should return diploma from the backend when snapshot exist ', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
// tslint:disable-next-line:no-commented-code
/* it('It should return diploma', () => {
const response = [{ mock: 'mock' } as any];
diplomaService.getDiploma('spinnerText').subscribe( i => {
expect(i).toEqual(response);
});
}); */
it('It should return diploma if snapshot doenst exist', () => {
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
const spyDocument = spyOn(diplomaService, 'getDiploma').and.callThrough();
const response = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(response, 200);
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
afwHttp.returnOnlyResponse();
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
expect(spyDocument).toHaveBeenCalledWith('spinnerText');
});
// tslint:disable-next-line:no-identical-functions
it('It should save diploma record to database', () => {
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'post').and.callThrough();
const spyDocument = spyOn(diplomaService, 'saveDiplomaMetaData').and.callThrough();
const response = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(response, 200);
const result2 = diplomaService.saveDiplomaMetaData(false, 'spinnerText');
result2.subscribe(() => {
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
// tslint:disable-next-line:no-commented-code
expect(spyDocument).toHaveBeenCalledWith(false, 'spinnerText');
});
afwHttp.returnOnlyResponse();
});
it('It should save documents for diploma record', fakeAsync(() => {
const spy = spyOn(multiFileUploadServiceMock, 'syncFilesWithBackend').and.callThrough();
const spyFeedback = spyOn(feedbackStoreServiceMock, 'addErrorMessage');
multiFileUploadServiceMock.setResponse([{ error: 'error' }]);
diplomaService.saveDocumentForDiploma([{} as any], () => { }, MultiFileUploadResourcesModel.keys, { key: 'diploma', value: 'document' });
expect(spy).toHaveBeenCalledWith('api/register/teachers/current/diploma/documents', [{}],
MultiFileUploadResourcesModel.keys.bijlageToevoegenSpinnerTekst,
MultiFileUploadResourcesModel.keys.bijlageVerwijderenSpinnerTekst
);
tick();
expect(spyFeedback).toHaveBeenCalled();
}));
// tslint:disable-next-line:no-identical-functions
it('should return document list ', fakeAsync(() => {
const apiString = 'api/register/teachers/current/diploma';
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
const spyDocumentList = spyOn(diplomaService, 'getDiplomaDocumentList').and.callThrough();
const response = { 'mock': 'mockResult' };
multiFileUploadServiceMock.setResponse([{}]);
afwHttp.setupOnlyResponse(response, 200);
const result2 = diplomaService.getDiplomaDocumentList('spinnerText');
result2.subscribe(() => {
expect(spyHttp).toHaveBeenCalledWith(apiString, 'spinnerText');
expect(spyDocumentList).toHaveBeenCalledWith('spinnerText');
expect(spyDocumentList).not.toBeNull();
});
afwHttp.returnOnlyResponse();
}));
// tslint:disable-next-line:no-identical-functions
it('It should return diplomaSnapshot', () => {
diplomaStoreServiceMock.returnState(Object.assign({}, this.diplomaState));
const diplomaState = diplomaService.getDiplomaSnapshot();
expect(diplomaState).toEqual(Object.assign({}, this.diplomaState));
});
});
I have it now like this:
it('It should return diploma from the snapshot as an observable ', () => {
const expected = { code: '00100-00101', test: 'test' };
afwHttp.setupOnlyResponse(expected, 200);
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
diplomaStoreServiceMock.returnState({diploma: expected});
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
afwHttp.returnOnlyResponse();
expect(spyHttp).not.toHaveBeenCalledWith();
});
But then I will get this error:
Services: DiplomaService > It should return diploma from the snapshot as an observable Expected undefined to equal 'mockResult'. Error: Expected undefined to equal 'mockResult'. at at SafeSubscriber._next (http://localhost:9877/src/app/shared/services/src/diploma.service.spec.ts?:65:93) at SafeSubscriber.push.../../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.__tryOrUnsub (http://localhost:9877/E:/Projects/Source/Repos/VLR/Web/vlrworkspace/node_modules/rxjs/_esm5/internal/Subscriber.js?:196:1) at SafeSubscriber.push.../../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.next (http://localhost:9877/E:/Projects/Source/Repos/VLR/Web/vlrworkspace/node_modules/rxjs/_esm5/internal/Subscriber.js?:134:1)
Ah, oke.
I have it now like this:
it('It should return diploma from the snapshot as an observable ', () => {
const expected = { 'mock': 'mockResult' };
afwHttp.setupOnlyResponse(expected, 200);
const spyHttp = spyOn(afwHttp, 'get').and.callThrough();
diplomaStoreServiceMock.returnState({diploma: expected});
diplomaService.getDiploma('spinnerText').subscribe(result => expect(result['mock']).toEqual('mockResult'));
afwHttp.returnOnlyResponse();
expect(spyHttp).not.toHaveBeenCalledWith();
});
and it works
