Laravel Route Model Binding: destroy method not grab necessary info

Question

Here is my controller for ProducerType model:

namespace App\Http\Controllers;

use App\ProducerType;
use App\Http\Requests\ValidateProducerTypes;
use Illuminate\Http\Request;

class ProducerTypeController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }

    ...

    public function destroy(ProducerType $producerType)
    {
        $producerType->delete();
        return redirect('/producers');
    }
}

And here is my model:

namespace App;

use Illuminate\Database\Eloquent\Model;

class ProducerType extends Model
{
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'nome'
    ];
}

View:

<form action="/producers-type/{{ $type->id }}" method="POST">
    @csrf
    @method('DELETE')
    <button type="submit" class="btn-icon">
        <img src="{{ asset('images/times-circle-regular.svg') }}" alt="">
    </button>
</form>

Routes:

Route::resource('producers-type', 'ProducerTypeController', [
    'only' => ['store', 'update', 'destroy']
])->middleware('permission:create users');

My problem is: $producerType variable is not grabbing the necessaries attributtes.

What attribute do you think it's not grabbing? The delete option just deletes the whole record, so it shouldn't be an issue. — aynber, Jan 22 '19 at 19:28
For delete you need to get an Instance which you're not getting. `$producerType->delete();` $producerType here will be NULL so no delete will occur. You can fetch an instance by id first and then delete! — Iftikhar uddin, Jan 22 '19 at 19:28
@Iftikharuddin This is what I'm trying to do. But `$producerType` is empty. — marcelo2605, Jan 22 '19 at 19:30
Specially delete route. I think your route is having `delete/{id}` which should be `delete/producerType` Can you check it from `route:list` command! — Iftikhar uddin, Jan 22 '19 at 19:38
Here is the specific line on route list: `DELETE | producers-type/{producers_type} | producers-type.destroy | App\Http\Controllers\ProducerTypeController@destroy | web,permission:create users,auth` — marcelo2605, Jan 22 '19 at 19:39
@Mozammil I try this way using this action without success. Even I accept an answer, I'm trying to make model binging works. — marcelo2605, Jan 22 '19 at 20:12
I don't know if it relevant, but I still have a route called `producers` — marcelo2605, Jan 22 '19 at 20:22

score 6 · Answer 1 · answered Jan 22 '19 at 20:42

6

Although the answer above gives a solution to the problem, I finnaly found the problem on my code!

From the Laravel documentation for Route Model Binding:

Since the $user variable is type-hinted as the App\User Eloquent model and the variable name matches the {user} URI segment, Laravel will automatically inject the model instance that has an ID matching the corresponding value from the request URI. If a matching model instance is not found in the database, a 404 HTTP response will automatically be generated.

This is my problem: I'm using $producerType variable and Laravel is expecting $producers_type because my route producers-type/{producers_type}.

answered Jan 22 '19 at 20:42

marcelo2605

2,734
4
29
55

Right check my comment 'Specially delete route. I think your route is having `delete/{id}` which should be `delete/producerType` Can you check it from `route:list` command!' – Iftikhar uddin Jan 23 '19 at 03:56
I'm using {add_product_log} in my route and using $addProductLog in my method and it works. I was originally just using AddProductLog $log, but it was missing attributes. AddProductLog $addProductLog works now. hope that helps others. – MicB Aug 14 '21 at 22:08

Iftikhar uddin · Answer 2 · 2019-01-22T19:45:36.133

1

Try changing:

public function destroy(ProducerType $producerType)
{
    $producerType->delete();
    return redirect('/producers');
}

to

public function destroy($id)
{
    $producerType = ProducerType::find($id);
    $producerType->delete();
    return redirect('/producers');
}

edited Jan 22 '19 at 19:45

answered Jan 22 '19 at 19:40

Iftikhar uddin

3,117
3
29
48

Nothing changes – marcelo2605 Jan 22 '19 at 19:42
I think the problem is related the way I'm using Service Container. – marcelo2605 Jan 22 '19 at 19:45
@marcelo2605 check the update answer please! Also `dd($id` if it's coming or not! – Iftikhar uddin Jan 22 '19 at 19:45
1

This works. You know why I'm can't grabbing the id using Service Container? – marcelo2605 Jan 22 '19 at 19:50
@marcelo2605 don't know with this case. However I will have to try it myself! Glad to know it worked! – Iftikhar uddin Jan 22 '19 at 19:51
1

Ok, thanks for the help. I believe using `$id` is not the better way, because user can change the value on DOM. – marcelo2605 Jan 22 '19 at 19:53
Yes I agree with you. I'm studying the service container way :) – Iftikhar uddin Jan 22 '19 at 19:54

Laravel Route Model Binding: destroy method not grab necessary info

2 Answers2