using zipArchive addFile() will not add image to zip

Question

I've been at this for a while. This actually worked one time, then never again. it simply does not create the zip file. The file does exist.

$zip = new ZipArchive();
$filename = "./test" . time() .".zip";

if ($zip->open($filename, ZIPARCHIVE::CREATE)!==TRUE) {      
    exit("cannot open <$filename>\n");
}

$thisdir = "$_SERVER[DOCUMENT_ROOT]/zip";
$zip->addFile($thisdir . "/trash-icon.png", "/gabage.png");
echo "numfiles: " . $zip->numFiles . "\n";
echo "status:" . $zip->status . "\n";
$zip->close();

If I add something like

$zip->addFromString("testfilephp.txt", "#1 This is a test string added as testfilephp.txt.\n");

it creates the zip with the txt file in it.. but a no go for anytype of existing file.

`/trash-icon.png` is almost certainly wrong, as it points to the server's root directory. Are you 100% sure the files you are trying to add in fact exist? — Pekka, Mar 24 '11 at 17:23
Are you certain that /trash-icon.png actually exists, remembering that it is in the filesystem root directory — Mark Baker, Mar 24 '11 at 17:24
http://www.php.net/manual/de/function.ziparchive-addfile.php#101605 — mario, Mar 24 '11 at 17:25

JohnnyB · Answer 1 · 2014-01-31T12:53:31.867

14

The ZipArchive::addFile() method accepts the path to the file as its first parameter, but not all paths are created equal. addFile() method silently rejects the file and you never know what went wrong. As can be derived from the question, an alternative approach would be:

// $zip->addFile($file);
$content = file_get_contents($file);
$zip->addFromString(pathinfo ( $file, PATHINFO_BASENAME), $content);

In addition to getting the code working, file_get_contents() also generates decent error messages.

edited Jan 31 '14 at 12:53

answered Jan 31 '14 at 12:26

JohnnyB

151
1
5

Clever workaround! I could find my error this way. I was also saved from going insane! – dsnunez Dec 09 '14 at 14:26
Thanks for the workaround. Even if the file is_readable add file failed. – Guillaume Alouege Jan 18 '16 at 10:38
This was the answer that resolved the issue for me. Thank you. – technology101010 Nov 05 '17 at 20:55
Can someone explain to me WHY addfile() is failing silently? – abaumg Mar 16 '21 at 09:46

score 2 · Answer 2 · answered Mar 24 '11 at 17:23

2

The ZipArchive::addFile() method accepts the path to the file as its first parameter.

Here, you are using :

$zip->addFile("/trash-icon.png", "/gabage.png");

Which means you are trying to add the /trash-icon.png file to your archive.

Are you sure this file exists ?

Note there is a / at the beginning of that file's path, which indicates it's an absolute path.
Maybe that / should be removed, to use a relative path ?

answered Mar 24 '11 at 17:23

Pascal MARTIN

395,085
80
655
663

Sorry this was a bad example of one of the many iterations I tried. code is updated – Vance Mar 24 '11 at 17:29

score 1 · Answer 3 · answered Nov 25 '15 at 12:12

I had similar kind of issue and it was related with the file that I was going to add to the zip archive.

Before adding file to zip archive, it's always better to check if the file exists.

$thisdir = "$_SERVER[DOCUMENT_ROOT]/zip";
if (file_exists($thisdir . "/trash-icon.png")) {
    $zip->addFile($thisdir . "/trash-icon.png", "/gabage.png");
}

using zipArchive addFile() will not add image to zip

3 Answers3

Linked