Button needs to be clicked twice to work - why?

Question

My issue is the Button in my activity needs to be clicked twice to make the code execute written in the onClick method. While I am sharing my Activity code and Layout file code. Please guide me to solve the issue.

Activity (Fragment)

public class SelfFamilyInfoActivity extends Fragment {

Button btnUpdateFamily;

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, 
Bundle savedInstanceState) {

    View v = inflater.inflate(R.layout.self_mem_details_family_info, 
  container, false);

    try {

        btnUpdateFamily = v.findViewById(R.id.btnUpdateFamily);

        btnUpdateFamily.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

                Toast.makeText(getActivity(), "Button Clicked", 
        Toast.LENGTH_SHORT).show();

            }
        });


    } catch (Exception e) {
        e.printStackTrace();
    }

    return v;

}

@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

}
}

Layout File

<?xml version="1.0" encoding="utf-8"?>
<android.support.v4.widget.NestedScrollView 
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/main_layout"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fillViewport="true"
android:scrollbars="vertical">

<ScrollView

    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:fillViewport="true"
    android:scrollbars="vertical">

    <LinearLayout

        android:id="@+id/llLayout"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_margin="12dp"
        android:orientation="vertical">


            <LinearLayout
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:layout_gravity="bottom"
                android:layout_marginTop="10dp"
                android:layout_marginBottom="10dp"
                android:gravity="center">

                <Button
                    android:id="@+id/btnUpdateFamily"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content"
                    android:layout_marginTop="5dp"
                    android:layout_marginBottom="5dp"
                    android:background="@drawable/button_background"
                    android:paddingLeft="10dp"
                    android:paddingRight="10dp"
                    android:text="Update Family Info"
                    android:textColor="@color/buttonTextColorWhite"
                    android:textSize="18sp" />

            </LinearLayout>


        </LinearLayout>

 </ScrollView>
 </android.support.v4.widget.NestedScrollView>

While this fragment is being initialized in Another MainActivity.

its working on the second click. while it is supposed to work on first click. — java bee, Jan 04 '19 at 10:42
Do you mind removing the `try-catch` around the button initialization and see if there's an actual exception thrown? — Yasin YILDIRIM, Jan 04 '19 at 10:48
@MilanPansuriya : on using OnClick in xml i get exception Could not find method btnFamilySubmit(View) in a parent or ancestor Context for android:onClick attribute NOTE: I have declared the method in fragment also. — java bee, Jan 04 '19 at 10:53
could you please try adding "clickable" and "focusable" params as true in xml ? — Chithra B, Jan 04 '19 at 10:55
Might be worth a try, can you try onTouch instead of onClick? — Nero, Jan 04 '19 at 10:56
@MilanPansuriya : in XML- android:onClick="btnTest" in Activity - public void btnTest(View v){ Toast....} — java bee, Jan 04 '19 at 10:57
@javabee I tested your code and it works, maybe there is another problem with the activity, can you add the code of the activity, try with other devices — Ahmed.ess, Jan 04 '19 at 11:00
Guys. It worked in first run , it didnt work again. please give more suggestions. — java bee, Jan 04 '19 at 11:46
@Ahmed.ess : I am trying this on 3 devices i have. on all of them it doesnt work. — java bee, Jan 04 '19 at 11:46

Tariqul Islam · Answer 1 · 2019-01-04T12:18:21.720

1

For fragment it is good to use your all view click in onViewCreated method. May be view not prepared but you start clicking . And you use try catch block did you see any exception in your log. I am not sure. But you can try your click listener in your onViewCreated method.

UPDATED try to use this code. this code working in my section

 Button btnUpdateFamily;
@Nullable
@Override
public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
    View v = inflater.inflate(R.layout.self_mem_details_family_info,
            container, false);

    return v;
}

@Override
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
    super.onViewCreated(view, savedInstanceState);
    btnUpdateFamily = view.findViewById(R.id.btnUpdateFamily);

    btnUpdateFamily.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {

            Toast.makeText(getActivity(), "Button Clicked",
                    Toast.LENGTH_SHORT).show();

        }
    });


}

edited Jan 04 '19 at 12:18

answered Jan 04 '19 at 10:52

Tariqul Islam

680
6
14

Thanks brother. This Worked for me. – java bee Jan 04 '19 at 11:04
Welcome! @java bee – Tariqul Islam Jan 04 '19 at 11:27
hi. I guess the problem is not solved yet. i run the app and it worked on first run while applying to the changes you suggested. and it is giving the same issue now. buttons needs to be clicked twice to work. – java bee Jan 04 '19 at 11:29
buttonName.bringToFront(); try it – Tariqul Islam Jan 04 '19 at 11:31
still the same. Sorry for removing the answer flag. I am badly in need to resolve this issue. – java bee Jan 04 '19 at 11:45
It worked in my section well. try to use this code in you r fragment class. i updated my answer – Tariqul Islam Jan 04 '19 at 12:17
i have changed my code according to your code. but still sometimes the button works on first click and sometimes on second click. I think the issue is in creating the view. I will take some more efforts to resolve this issue. and post it here. thanks for the brilliant help tariqul and other friends. – java bee Jan 04 '19 at 12:40
i used your view. I have doubt your activity. It will good to show your activity xml – Tariqul Islam Jan 04 '19 at 12:43

Button needs to be clicked twice to work - why?

1 Answers1