java.lang.AssertionError: Status expected:<200> but was:<404> in Junit test

Question

I want to create JUnit test for Rest api and generate api doc. I want to test this code:

Rest controller

@RestController
@RequestMapping("/transactions")
public class PaymentTransactionsController {

@Autowired
private PaymentTransactionRepository transactionRepository;

@GetMapping("{id}")
    public ResponseEntity<?> get(@PathVariable String id) {
        return transactionRepository
                .findById(Integer.parseInt(id))
                .map(mapper::toDTO)
                .map(ResponseEntity::ok)
                .orElseGet(() -> notFound().build());
    }
}

Repository interface

public interface PaymentTransactionRepository extends CrudRepository<PaymentTransactions, Integer>, JpaSpecificationExecutor<PaymentTransactions> {

    Optional<PaymentTransactions> findById(Integer id);
}

I tried to implement this JUnit5 test with mockito:

@ExtendWith({ RestDocumentationExtension.class, SpringExtension.class })
@SpringBootTest(classes = PaymentTransactionsController.class)
@WebAppConfiguration
public class PaymentTransactionRepositoryIntegrationTest {
    .....
    private MockMvc mockMvc;

    @MockBean
    private PaymentTransactionRepository transactionRepository;

    @BeforeEach
    void setUp(WebApplicationContext webApplicationContext,
              RestDocumentationContextProvider restDocumentation) {

        PaymentTransactions obj = new PaymentTransactions(1);

        Optional<PaymentTransactions> optional = Optional.of(obj);      

        PaymentTransactionRepository processor = Mockito.mock(PaymentTransactionRepository.class);
        Mockito.when(processor.findById(Integer.parseInt("1"))).thenReturn(optional);       

        this.mockMvc = MockMvcBuilders.webAppContextSetup(webApplicationContext)
              .apply(documentationConfiguration(restDocumentation))
              .alwaysDo(document("{method-name}", preprocessRequest(prettyPrint()), preprocessResponse(prettyPrint())))
              .build();
    }

    @Test
    public void testNotNull() {
        assertNotNull(target);
    }

    @Test
    public void testFindByIdFound() {
        Optional<PaymentTransactions> res = target.findById(Integer.parseInt("1"));
//        assertTrue(res.isPresent());
    }

    @Test
    public void indexExample() throws Exception {
            this.mockMvc.perform(get("/transactions").param("id", "1"))
                .andExpect(status().isOk())
                .andExpect(content().contentType("application/xml;charset=UTF-8"))
                .andDo(document("index-example", preprocessRequest(prettyPrint()), preprocessResponse(prettyPrint()), links(linkWithRel("crud").description("The CRUD resource")), responseFields(subsectionWithPath("_links").description("Links to other resources")),
                    responseHeaders(headerWithName("Content-Type").description("The Content-Type of the payload, e.g. `application/hal+json`"))));
    }
}

I get error:

java.lang.AssertionError: Status expected:<200> but was:<404>

What his the proper way to to make GET request to the above code? Probably I need to add response OK when message is send back?

status 404 means your request for "/transactions" is not found, can you use ` MockMvcRequestBuilders.get("/transactions/{id}", 1) `... — pramesh, Dec 23 '18 at 15:48
I also tried this but I get `java.lang.AssertionError: Status expected:<200> but was:<404>` — Peter Penzov, Dec 23 '18 at 17:47
@PeterPenzov Did you check whether your webApplicationContext is getting initialized and injected properly? — Akash, Dec 24 '18 at 07:08

score 2 · Answer 1 · answered Jun 28 '21 at 15:48

2

hi in my case i needed @MockBean of controller and all services that is was autowireing ;)

answered Jun 28 '21 at 15:48

Matus Babinsky

125
9

score 1 · Answer 2 · answered Jul 24 '20 at 10:58

1

Instead of @PostMapping and @GetMapping which caused same problem while @RequestMapping in controller helped

answered Jul 24 '20 at 10:58

Parameshwar

856
8
16

This worked to me, why ??? – AngularPlayer Mar 22 '22 at 10:31

Pradip Karki · Answer 3 · 2018-12-24T19:03:11.760

0

It's a path variable, so instead of using param value, please use path variable.

For MvcResult import, you can import org.springframework.test.web.servlet

import org.springframework.test.web.servlet.MockMvc;
import org.springframework.test.web.servlet.MvcResult;

...

given(target.findById(anyInt())).willReturn(Optional.of(new PaymentTransactions(1))).andReturn();

MvcResult result = this.mockMvc.perform(get("/transactions/1")
                .accept("application/xml;charset=UTF-8")).andReturn();

String content = result.getResponse().getContentAsString();

this.mockMvc.perform(get("/transactions/1")
            .accept("application/xml;charset=UTF-8"))
            .andExpect(status().isOk())
            .andDo(document("index-example", preprocessRequest(prettyPrint()), preprocessResponse(prettyPrint()), links(linkWithRel("crud").description("The CRUD resource")), responseFields(subsectionWithPath("_links").description("Links to other resources")),
                responseHeaders(headerWithName("Content-Type").description("The Content-Type of the payload, e.g. `application/hal+json`"))));

edited Dec 24 '18 at 19:03

answered Dec 23 '18 at 17:02

Pradip Karki

662
1
8
21

I get `java.lang.AssertionError: Status expected:<200> but was:<404>` at this line `.andExpect(status().isOk())` Any idea why? – Peter Penzov Dec 23 '18 at 17:47
Can you please try add below line before `this.mockMvc.perform` `given(target.findById(anyInt())).willReturn(Optional.of(new PaymentTransactions(1)));` and see if this works? – Pradip Karki Dec 23 '18 at 18:12
@PeterPenzov sure, please try it. – Pradip Karki Dec 23 '18 at 21:07
I tried it but I get again error 404. Any idea how to debug it? – Peter Penzov Dec 23 '18 at 21:10
yea, you can definitely. I updated the answer, please look at it. – Pradip Karki Dec 23 '18 at 21:16
Do you know what maven dependencies I have to import for andReturn();? – Peter Penzov Dec 23 '18 at 21:42
By the wya I use JUnit 5 looks like your code is for JUnit 4? – Peter Penzov Dec 23 '18 at 22:35
you can import `import org.springframework.test.web.servlet.MvcResult;` you can get the library https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-test. – Pradip Karki Dec 24 '18 at 06:49
With cast I managed to implement it but I get compilation error. This code is probably for JUnit 4? – Peter Penzov Dec 24 '18 at 14:01
Yea, It’s in jUnit 4, but idea is you can printout, debug results using MvcResult and other helpful methods. – Pradip Karki Dec 24 '18 at 18:36
one example I found using jUnit 5 is: https://stackoverflow.com/questions/48727758/spring-5-with-junit-5-mockito-controller-method-returns-null, but it should be same. Can you post the compilation error message too? and your url should be like /transactions/1 – Pradip Karki Dec 24 '18 at 19:05

score 0 · Answer 4 · answered Dec 25 '18 at 07:06

0

Can you try this..

public class PaymentTransactionsControllerTest {

private MockMvc mvc;

@InjectMocks
PaymentTransactionsController paymentTransactionsController;

@MockBean
private PaymentTransactionRepository processor;

@Before
public void setUp() {
    MockitoAnnotations.initMocks(this);
    mvc = MockMvcBuilders.standaloneSetup(paymentTransactionsController).build();
}

@Test
public void indexExample() throws Exception {

    PaymentTransactions obj = new PaymentTransactions(1);
    Optional<PaymentTransactions> optional = Optional.of(obj);  

    Mockito.when(processor.findById(Integer.parseInt("1"))).thenReturn(optional); 

    MvcResult result = mvc.perform(MockMvcRequestBuilders.get("/transactions/{id}", 1))
            .andDo(print())
            .andExpect(status().isOk())
            .andReturn();

    Assert.assertNotNull(result.getResponse().getContentAsString());
}
}

answered Dec 25 '18 at 07:06

pramesh

501
3
11

I get NPE at this line `MvcResult result = mockMvc.perform(MockMvcRequestBuilders.get("/transactions/{id}", 1))` – Peter Penzov Dec 25 '18 at 09:09
can you replace by this code in your setup, i think PaymentTransactionsController is not injected in your test so you are getting NPE `@Before public void setUp() { MockitoAnnotations.initMocks(this); mvc = MockMvcBuilders.standaloneSetup(new PaymentTransactionRepository()).build(); }` – pramesh Dec 26 '18 at 07:44
i have small demo for unit test in my git repo... it can help you.. https://github.com/prameshbhattarai/spring-boot-demo – pramesh Dec 26 '18 at 07:47
I get again NPE at the same line. – Peter Penzov Dec 26 '18 at 08:45
can you provide me the stack trace for your exception... also did you check my repo.. – pramesh Dec 26 '18 at 09:09
Here is the output: https://pastebin.com/06b7XsFH I will test your code example today. – Peter Penzov Dec 26 '18 at 13:18

java.lang.AssertionError: Status expected:<200> but was:<404> in Junit test

4 Answers4

Linked