77

I'm currently converting my MsTest unit tests to xUnit. With xUnit, is there a way to test exception messages? Is it correct to test exception messages as opposed just the exception type?

sduplooy
  • 14,340
  • 9
  • 41
  • 60

8 Answers8

137

I think it is correct to test for both Exception type and message. And both are easy in xUnit:

var exception = Assert.Throws<AuthenticationException>(() => DoSomething());
Assert.Equal(message, exception.Message);
the_joric
  • 11,986
  • 6
  • 36
  • 57
9

Better to use the Record.Exception method as it matches the AAA pattern:

    [Fact]
    public void Divide_TwoNumbers_ExpectException()
    {
        var sut = new Calculator();
        var exception = Record.Exception(() => sut.Divide(10, 0));
        Assert.IsType(typeof(DivideByZeroException), exception);
    }

Hope this helps ...

user1829319
  • 691
  • 1
  • 8
  • 22
  • 2
    xUnit2007: Do not use typeof(System.DivideByZeroException) expression to check the type. Instead you can use: Assert.IsType(exception) – ggeorge Nov 28 '20 at 12:18
2

Something like this

 var ex = Record.Exception(() => DoSomeThing());
 Assert.IsType(typeof(ArgumentNullException), ex);
 Assert.True(ex.Message.Contains("Your exception message"));
1

BTW, Resharper prefers not to use typeof and suggests Assert.IsType instead, e.g.

var ex = Record.Exception(() => new FooController(null, null));
Assert.IsType<ArgumentNullException>(ex);
Andy Creigh
  • 113
  • 8
1

xUnit uses Assert.Throws to test for exception types. You could catch the exception and Assert against the message if you needed. I think in general you want to test that the expected exception is thrown, and the exact message is really not necessary.

Assert.Throws<ArgumentNullException>()

The exception might be if you have a custom exception you are unit testing and you want to make sure the message generated is what you expect. Or if there are two ways that the same exception type can be thrown but with different messages, then asserting against the message would be valuable

NerdFury
  • 18,876
  • 5
  • 38
  • 41
0

An exception is no different than any other expected result of your test. It is natural to test that the message is the correct one as two different messages can come in the same exception type. However - I personally don't think of it as mandatory, at least not in all exceptions.

In our project each application exception also has a 'Message' object attached to it, so we verify the MessageId only, we don't verify that the message arguments are correct or the message's text. E.g if the message text is "Wrong parameter <{0}> was provided", we don't check that the argument that was passed to format {0} is as expected - this is not the intent. The message has a unique id - so we verify that the MessageID on the exception is 'WRONG_PARAMETER_PROVIDED'.

RonK
  • 9,472
  • 8
  • 51
  • 87
0

In the light of async stuff, new version would be

var ex = await Record.ExceptionAsync(() => myMethod(myParams));
Assert.IsType<SomeException>(ex);
Assert.Equal("My text of the error.", ex.Message);
Nico Degraef
  • 135
  • 1
  • 9
-1

xUnit website also mentions "Record.Exception" construct.

Csaba Toth
  • 10,021
  • 5
  • 75
  • 121