Overriding move-assignement operator

Asked Dec 04 '18 at 08:19

Active Dec 04 '18 at 08:30

Viewed 33 times

I get a warning from clang-tidy when overriding the move-assignment operator in a subclass and moving the fields of the sub class after invoking the move-assignment operator of the base class.

Example:

class Base{
     ...
     Base& operator=(Base&& other) {...}
};

class Sub : public Base {
     OtherClass n;
     Sub& operator=(Sub&& other) {
         Base::operator=(std::move(other));
         n = std::move(other.n); // <-- Here is the warning
         return *this;
     }
};

The warning I get is:

Clang-Tidy: 'other' used after it was moved

What is the correct way to override the operator?

edited Dec 04 '18 at 08:30

asked Dec 04 '18 at 08:19

peter

Show the warning you get? – Marc Glisse Dec 04 '18 at 08:21
What warning??? – AnT stands with Russia Dec 04 '18 at 08:21
Control flow reaches end of the function without return statement while function is supposed to return a reference to `Sub`. This causes Undefined Behaviour. Clang-Tidy warning is pretty much useless. – user7860670 Dec 04 '18 at 08:25
Uh, this isn't a duplicate of that question at all... – Marc Glisse Dec 04 '18 at 08:29
@VTT i wanted to show some sample code and not copy code from my project i fix the missing return. this has nothing to do with the question. – peter Dec 04 '18 at 08:30
clang-tidy seems wrong. Maybe you can appease it by swapping the 2 lines? Or use `Base::operator=(static_cast(other))`. – Marc Glisse Dec 04 '18 at 08:31
@peter Code sample is supposed to be [Minimal, Complete, and Verifiable example](https://stackoverflow.com/help/mcve). You can't just crop everything. Also I didn't vote to close as duplicate... – user7860670 Dec 04 '18 at 08:31
@MarcGlisse thanks for these tips :) both remove the warning – peter Dec 04 '18 at 08:33
@VTT yeah you are correct and i fixed the missing return statement. – peter Dec 04 '18 at 08:34
I don't get the duplicate.. My question is about the operator and not the constructor. – peter Dec 04 '18 at 08:35

Overriding move-assignement operator

0 Answers0