"Trying to get property 'id' of non-object"

Question

I want to get the id of the cycles table so that I can store to the mortalities table.

SELECT `id` FROM `cycles` 
WHERE `date_start_raise` <= request('date_input') 
AND `date_end_raise` >= request('date_input')`

Converted to Laravel Query Builder:

<?php

$cycle = DB::table('cycles')->select('id')
    ->where('date_start_raise', '<=', request('date_input'))
    ->where('date_end_raise', '>=', request('date_input'))
    ->get();

request('date_input') was from the MortalityController

MortalityController.php

    public function store(Request $request)
{



    $this->validate($request, array(
    'date_input' => 'required|date',
    'number_of_mortality' => 'required|numeric',
    'chicken_age' => 'required|numeric'
    ) );

    $cycle = DB::table('cycles')->select('id')
     ->where('date_start_raise', '<=', request('date_input'))
      ->where('date_end_raise', '>=', request('date_input')) ->get(); 

    return Mortality::create([
        'date_input' => request('date_input'),
        'number_of_mortality' => request('number_of_mortality'),
        'chicken_age' => request('chicken_age'),
        'cause_of_death' => request('cause_of_death'),
        'cycle_id'  => $cycle->first()->id,
        'user_id'  => Auth::id()
    ]);

}

After that I got an error:

"message": "SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: '[]' for column 'cycle_id' at row 1 (SQL: insert into mortalities (date_input, number_of_mortality, chicken_age, cause_of_death, cycle_id, user_id, updated_at, created_at) values (2018-09-04, 25, 2, , [], 1, 2018-11-28 07:38:01, 2018-11-28 07:38:01))"

I fix the error but new error appeared

"message": "Trying to get property 'id' of non-object"

Can anyone please help me?

Where is the $ in the request? It's a variable, not a function — Samuel Aiala Ferreira, Nov 28 '18 at 08:11
When you call request('number_of_mortality'), should be $request->get('number_of_mortality'), — Samuel Aiala Ferreira, Nov 28 '18 at 08:20

score 0 · Answer 1 · answered Nov 28 '18 at 08:04

0

use like that (u are passing collection to insert)

$cycle = DB::table('cycles')->select('id')
        ->where('date_start_raise','<=',request('date_input'))
        ->where('date_end_raise','>=',request('date_input'))
        ->first()->id;

answered Nov 28 '18 at 08:04

Jignesh Joisar

13,720
5
57
57

new error appeared `"message": "Trying to get property 'id' of non-object"` – Nov 28 '18 at 08:09
Please add some explanation to your answer such that others can learn from it - what are the crucial parts? – Nico Haase Nov 28 '18 at 08:56

score 0 · Accepted Answer · answered Nov 28 '18 at 08:53

0

You need to get values from $request object by using $request->get('your_id') or

$request->input('your_id')

Try this..!!

$cycle = DB::table('cycles')->select('id')
            ->where('date_start_raise','<=',$request->get('date_input'))
            ->where('date_end_raise','>=',$request->get('date_input'))
            ->first();

OR

$cycle = DB::table('cycles')->select('id')
                ->where('date_start_raise','<=',$request->get('date_input'))
                ->where('date_end_raise','>=',$request->get('date_input'))
                ->get();

then

foreach($cycle as $value){
  //extract data from $value
}

Hop its work for you ...

answered Nov 28 '18 at 08:53

Mujeeb Khan

48
8

where the foreach should i place – Nov 28 '18 at 08:55
`foreach($cycle as $value){ $id = $value->id; }` – Mujeeb Khan Nov 28 '18 at 10:22
use foreach loop to extract the id from object before return; then this `$id` you can use your return query... make sure your database should working fine. – Mujeeb Khan Nov 28 '18 at 10:24
what is the final format of the code ? sorry for asking too much – Nov 28 '18 at 10:38
error shows `Invalid argument supplied for foreach()` can i get the final format of the code ? – Nov 28 '18 at 10:59
if you are using `->get();` then its return object. that object use in `foreach()` – Mujeeb Khan Nov 28 '18 at 11:40
`Invalid argument supplied for foreach()` means you are using non-object in foreach, – Mujeeb Khan Nov 28 '18 at 11:42
`$cycle = DB::table('cycles')->select('id') ->where('date_start_raise','<=',$request->get('date_input')) ->where('date_end_raise','>=',$request->get('date_input')) ->get();` – Mujeeb Khan Nov 28 '18 at 11:42
then `foreach($cycle as $value){ $id = $value->id; }` after that, use`$id` instead of `$cycle->first()->id` in your last query where you are returning. – Mujeeb Khan Nov 28 '18 at 11:44
also, check values in request object by using `echo $request->get('date_input)` then, tell me about result – Mujeeb Khan Nov 28 '18 at 11:48
new error `undefined variable: id` line 64 `'cycle_id' => $id` – Nov 28 '18 at 11:53
define `$id` before using in `foreach()` loop – Mujeeb Khan Nov 28 '18 at 12:05
may be your `cycle_id' have 'not null' constraint, so check also this. – Mujeeb Khan Nov 28 '18 at 12:07
use `if(count($cycle)>0){ foreach($cycle as $value){ $id = $value->date_input;} }else{ $id = 0; }` – Mujeeb Khan Nov 28 '18 at 12:25

score -1 · Answer 3 · answered Nov 28 '18 at 08:08

-1

Check this !!

return Mortality::create([
        'date_input' => request('date_input'),
        'number_of_mortality' => request('number_of_mortality'),
        'chicken_age' => request('chicken_age'),
        'cause_of_death' => request('cause_of_death'),
        'cycle_id'  => $cycle->first()->id,
        'user_id'  => Auth::id()
    ]);`

answered Nov 28 '18 at 08:08

Ambalan

9
2

new error appeared `"message": "Trying to get property 'id' of non-object"` – Nov 28 '18 at 08:11
`$cycle = DB::table('cycles')->select('id') ->where('date_start_raise', '<=', request('date_input')) ->where('date_end_raise', '>=', request('date_input')) ->get(); dd($cycle->count()) // if this is zero check your database` – Ambalan Nov 28 '18 at 08:14
it was 0 but the database is empty – Nov 28 '18 at 08:16
i check my database but it was empty – Nov 28 '18 at 08:26
Please add some explanation to your answer such that others can learn from it - what are the crucial parts? – Nico Haase Nov 28 '18 at 08:55

"Trying to get property 'id' of non-object"

3 Answers3