0

I'm trying to validate the following from the text field: 1. It's not empty (has a value) 2. Is a number (not some other character) 3. Is with a certain min and max (range)

For this I use an empty validator, a regex validator and a predicate validator respectively and combine them. However it seems to only utilize the last validator in the list and ignores the others.

Here is the code:

private final Spinner<Integer> createSpinner(ValueRange range, int initialValue){
        int min = (int) range.getMinimum();
        int max = (int) range.getMaximum();

        //TODO add validation in here
        Spinner<Integer> spinner = new Spinner<Integer>();
        spinner.setPrefSize(30, 30);
        spinner.getStyleClass().add(Spinner.STYLE_CLASS_SPLIT_ARROWS_VERTICAL);
        spinner.setEditable(true);

        SpinnerValueFactory.IntegerSpinnerValueFactory valueFactory = new SpinnerValueFactory.IntegerSpinnerValueFactory(min, max, initialValue);
        valueFactory.setConverter(new TimeIntegerStringConverter());
        valueFactory.setWrapAround(true);
        spinner.setValueFactory(valueFactory);

        //validation
        TextField editor = spinner.getEditor();
        validationSupport.registerValidator(editor, false, Validator.<String>combine(
                Validator.createEmptyValidator("Field cannot be empty",Severity.WARNING),
                checkInRangeValidator(range),
                checkIntegerValidator()
                ));

        return spinner;
    }

private static Validator<String> checkInRangeValidator(ValueRange range) {
        String message = String.format("Input value must be between [%d,%d]", (int) range.getMinimum(), (int) range.getMaximum());
        return Validator.<String>createPredicateValidator(
                s ->   range.isValidIntValue(Integer.valueOf(s)),
                message,
                Severity.ERROR
                );
    }

    private static Validator<String> checkIntegerValidator(){
        String message = "Input must be a number";
        return Validator.createRegexValidator(message, "\\d+", Severity.ERROR);

    }

I'm unsure why the validators are not combining. If I add them separately in the combine function each validator works. But together they don't.

1 Answers1

0
validationSupport.registerValidator(editor, false, Validator.<String>combine(
                emptyValidator,
                twoDigitValidator,
                new RangeValidator(range)
                ));


private final Validator<String> emptyValidator = (control,value) ->
             ValidationResult.fromErrorIf(control, "Value cannot be empty", StringExtended.isEmptyOrNullOrWhitespace(value));


    private final Validator<String> twoDigitValidator = (control,value) -> {
            return ValidationResult.fromErrorIf(control, "Value must consist of 2 digits", !value.matches("\\d{2}"));

    };

    private class RangeValidator implements Validator<String>{

        private ValueRange range;

        RangeValidator(ValueRange range){
            this.range = range;
        }

        @Override
        public ValidationResult apply(Control control, String value) {
            String message = String.format("Input value must be between [%d,%d]", (int) range.getMinimum(), (int) range.getMaximum());
            return ValidationResult.fromErrorIf(control, message,  !range.isValidIntValue(Integer.valueOf(value)));
        }

    }
  • I still have a problem when the incrementer/decrementer is used on the spinner the validation doesn't seem to work. Sigh. – LocoTangerine Oct 17 '18 at 09:21