96

I am getting a warning on a React site I built

./src/components/layout/Navbar.js [1]   Line 31:  The href attribute requires a valid 
address. Provide a valid, navigable address as the href value  jsx-a11y/anchor-is-valid

on the following code:

          <p>
            {isEmpty(profile.website) ? null : (
              <a
                className="text-white p-2"
                href={profile.website}
                target="#"
              >
                <i className="fas fa-globe fa-2x" />
              </a>
            )}
            {isEmpty(profile.social && profile.social.twitter) ? null : (
              <a
                className="text-white p-2"
                href={profile.social.twitter}
                target="#"
              >
                <i className="fab fa-twitter fa-2x" />
              </a>
            )}
            {isEmpty(profile.social && profile.social.facebook) ? null : (
              <a
                className="text-white p-2"
                href={profile.social.facebook}
                target="#"
              >
                <i className="fab fa-facebook fa-2x" />
              </a>
            )}
          </p>

Even though the warning appears only for the first link, the same warning occurs on the next link if I remove the first link temporarily or change the href of the first link to a static URL.

The links need to appear as just an icon.

I have tried things such as using a button (did not have the correct look), using a function to open the dynamic url, and trying to force the href to be a string by using '' + {profile.website}. Many other suggestions have not worked.

Is there a way to prevent the error, without changing the jsx-a11y rules? Is what I have done not a good pattern, or is it just a bug in React or JSX?

Henke
  • 4,445
  • 3
  • 31
  • 44
msm1089
  • 1,314
  • 1
  • 8
  • 19

21 Answers21

198

Use href="/#" to replace href="#" OR href="javascript:;" OR href="javascript:void(0);"

It should remove the warnings.

Tunji Oyeniran
  • 3,948
  • 1
  • 18
  • 16
  • 8
    the javascript trick doesn't seem to work in eslint 7.0.0 `The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles.` – Sonic Soul Jun 11 '20 at 19:41
  • 3
    The JS community... Shouldn't we at least wonder what the warning is about and discuss the implications of side-stepping it? – bluenote10 Nov 23 '20 at 20:05
  • 1
    And instead of using a hack to suppress the warning, why not simply tell the linter `// eslint-disable-next-line` on that particular line? – bluenote10 Nov 28 '20 at 09:31
  • This seems to be a silly warning for anchor links. – JoeD Mar 27 '23 at 15:16
37

These worked for me to get rid off the warning;

<a href="#/">...</a>  
<a href={() => false}>...</a>
Jonathan Akwetey Okine
  • 1,295
  • 2
  • 15
  • 18
22

I've used href="!#" to remove warnings.

ross
  • 2,684
  • 2
  • 13
  • 22
Bojan Vlatkovic
  • 229
  • 2
  • 2
17

This is just a warning not a error that href attribute requires a valid value as # points to nowhere you can add links to href attributes to remove this warnings or if you are still in early development phase just write

/* eslint-disable jsx-a11y/anchor-is-valid */

On top of your code it will remove the warnings from the terminal, the above line disables the rule for the specified file where it is written

/* eslint-disable jsx-a11y/anchor-is-valid */
import React from 'react';

const Header = () =>{
    return(
        <nav className="navbar navbar-expand-lg navbar-light bg-light">
            <a className="navbar-brand" href="#">Navbar</a>
            <button className="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">
                <span className="navbar-toggler-icon"></span>
            </button>
        </nav>
         )
}
Sandeep Mukherjee
  • 673
  • 1
  • 9
  • 17
16

To also prevent default I use this:

<a href="/#" onClick={(e) => e.preventDefault()}>Link Text</a>
13

Insert space after # so no more warning about it

replace href="#" to href="# " but better if use like that href="#something" => href="#profile"

gcs_dev
  • 351
  • 3
  • 7
11

please use <button> instead of <a> when there's no href attribute.

official reference

If you really have to use the a tag, it maybe help you:

<a href="#" onClick={ev => {ev.preventDefault(); onClick();}}>"Hello A Tag"</a>
TorvaldsDB
  • 766
  • 9
  • 8
10

try replacing

target="#"

to

target="_blank"
Rajbir Singh
  • 101
  • 1
  • 6
7

I got the similar warning for href, I did as follows. May be try this. I got rid of the warning and functionality is intact. I am not sure this is correct. But tried this.

let hrefLink = '#'; passed as a arg like href={hrefLink}
Eric Aya
  • 69,473
  • 35
  • 181
  • 253
5

If you are trying to render a page link dynamically then you can switch out an <a> tag for a <div> tag instead. The warning message will go away.

// DON't DO THiS
<a className="page-link" href="javascript:void(0);" onClick={() => onPageChange(page)}>
  {page}
</a>;

// TRY THIS INSTEAD
<div className="page-link" onClick={() => onPageChange(page)}>
  {page}
</div>;

If you put "javascript" word in the href attribute then you will get a RED WARNING:

index.js:1375 Warning: A future version of React will block javascript: URLs as a security precaution. Use event handlers instead if you can.

Reference: EsLint error resolution page

Anthony Avila
  • 311
  • 3
  • 6
5

I've used the href in tag a. it's remove warnings.

<a href>Pictures</a>
Infomaster
  • 793
  • 7
  • 8
3

You also can hide this warning adding a eslint-disable-next-line comment:

// eslint-disable-next-line
<a
    onClick={e => {
        // do something
    }}
>
    example
</a>
3

I've used the following to remove warnings.

<a href="/">
jnovack
  • 7,629
  • 2
  • 26
  • 40
Lê Vũ Lâm
  • 317
  • 4
  • 7
  • 3
    Hi, welcome to StackOverflow. A lot of times, people not only want an answer, but to learn why their mistake existed in the first place. Could you please elaborate on your answer so the OP and others can learn? – jnovack Sep 28 '20 at 10:12
1

If we have written correct url but it also gives the same error like I put www.reactjs.org then it also gives the same warning. To resolve these problem we have an attribute in anchor tag i.e.

<a
   className="App-link"
   href="https://reactjs.org"
   target="_blank"
   rel="noopener noreferrer"
    >
      Learn React
    </a>
  1. className used for style.
  2. href used for links.
  3. target used for open a link into new tab or not.
  4. Rel is used to outcome from that warning in react.
Nadeem Khan
  • 127
  • 2
  • 11
0

I don't see something wrong if I'm refering to this. https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md

Check in these links. Some people had the same problem than you and it comes from a Link component. They fix it in adding an exception to .eslintrc:

first link => https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/340 and the second link => How can I fix jsx-a11y/anchor-is-valid when using the Link component in React?

Let me know if it's helping.

0

Late to the game but surprised no one recommended window.location, which simply sets the same exact route as the current?

Other solutions such as "#", "/#", and "/" actually modify the current route right? For a more generic solution just use window.location to stay on the current page without modification.


<a href="window.location" onClick={...}> Better Solution </a>

Ergin
  • 9,254
  • 1
  • 19
  • 28
0

If you really want your anchor tag to have an onClick method you must use a valid href link orelse it will throw an error , The href attribute requires a valid value to be accessible. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles.

Change you button style with this property to make transparent

button{
        background-color: Transparent;
        background-repeat:no-repeat;
        border: none;
        cursor:pointer;
        overflow: hidden;
        outline:none;
}

and set the text inside the button to the resemble link color

I have use this color

.editcolor{
        color: #1890ff;
}

I resolved my errors with this method.

Dharman
  • 30,962
  • 25
  • 85
  • 135
Badal S
  • 507
  • 1
  • 3
  • 20
0

I tried but most of the answers above did not work for me since the newer eslint does not allow most of them. Instead, it mentions disabling eslint for the specific line.

Simply add:
// eslint-disable-next-line
to the line which comes just before the jsx line that throws error.

Also, add this comment within {/* ... */} else it will show error.

Usage: {/* // eslint-disable-next-line */ }}

They advise the same thing:
screenshot of error


Hope this solves it!

Vani Gupta
  • 505
  • 6
  • 13
0

You just need to change "#" to "# ". Good luck

0

  <li className="nav-item pointer">
     <a onClick={logout} href="/#"  className="nav-link">
        LOGOUT
     </a>
  </li>

or just use

href="/"

0

Do Not Use: <a href='#'>Something</a> but instead use: <a href='/'>Something</a>

Dejvi Epa
  • 53
  • 4