Wrapping httptest methods in a helper function

Question

In my handler tests, I use the pattern of serving a test request with an authentication token in the header a large number of times. To abstract this, and save myself a large number of lines, I've written the following function:

func serveTestReq(payload string, route string, method string, handlerfunc func(w http.ResponseWriter, r *http.Request), token string) {
        body := strings.NewReader(payload)
        req, err := http.NewRequest(method, route, body)
        Expect(err).NotTo(HaveOccurred())

        req.Header.Add("Content", "application/json")
        req.Header.Add("Authorization", "Bearer "+token)

        handler := authMiddleware(handlerfunc)
        rr := httptest.NewRecorder()
        handler.ServeHTTP(rr, req)

}

However if I call this function twice (to test for idempotent POSTs, for example) the request seems to only be served once. Is there something wrong with the above function?

There's nothing obvious in this function that would make it non-idempotent. You may need to include additional code to expose the problem. — Jonathan Hall, Sep 04 '18 at 08:08
I've found the problem - in `serveTestReq` I need to return `rr`, and check there for the HTTP Response. — category, Sep 04 '18 at 08:31

score 0 · Answer 1 · answered Sep 04 '18 at 08:44

The problem was that I wasn't checking for the HTTP Response generated in the function. The correct function looks like:

func serveTestReq(payload string, route string, method string, handlerfunc func(w http.ResponseWriter, r *http.Request), token string) *httptest.RepsonseRecorder {
        body := strings.NewReader(payload)
        req, err := http.NewRequest(method, route, body)
        Expect(err).NotTo(HaveOccurred())

        req.Header.Add("Content", "application/json")
        req.Header.Add("Authorization", "Bearer "+token)

        handler := authMiddleware(handlerfunc)
        rr := httptest.NewRecorder()
        handler.ServeHTTP(rr, req)

        return rr

}

Wrapping httptest methods in a helper function

1 Answers1