Intent.putExtra (key,value) is not working

Question

I got a ValueEventListener

   query.addValueEventListener(new ValueEventListener() {
        @Override
        public void onDataChange(DataSnapshot dataSnapshot) {
                final Intent intent = new Intent(BackgroundService.this, NextActivity.class);
                Task<String> t=genrate();//not null

                        t.addOnCompleteListener(new OnCompleteListener<String>() {
                            @Override
                            public void onComplete(@NonNull Task<String> task) {
                                if (task.isSuccessful()) {
                                 intent.putExtra("token",task.getResult());

            }
        } });
       intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
                PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, 0);
                mBuilder.setContentIntent(pendingIntent).setAutoCancel(true);
                mBuilder.setVisibility(VISIBILITY_SECRET);
                NotificationManagerCompat notificationManager = NotificationManagerCompat.from(BackgroundService.this);
                notificationManager.notify(121, mBuilder.build());

        @Override
        public void onCancelled(DatabaseError databaseError) {

        }
    });

The token key is missing from NextActivity.

getIntent().getExtras().getString("token")

return null.

What could be the problem ?

In this line: `PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, 0);` — Bertram Gilfoyle, Aug 25 '18 at 13:33

score 0 · Answer 1 · 2018-08-25T10:04:57.090

0

You need this flag: PendingIntent.FLAG_UPDATE_CURRENT in your PendingIntent
Change:

PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, 0);

to:

PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

edited Aug 25 '18 at 10:04

answered Aug 25 '18 at 09:17

yeah , i checked with logs all is fine , btw token is a long string – RichardIV Aug 25 '18 at 09:23
How long? and what is `task.getResult()`? – Aug 25 '18 at 09:26
@somebody so without the flag would you get the extra? – Aug 25 '18 at 11:38
yes , for debugging reasons i used the flag to update the pending intent – RichardIV Aug 25 '18 at 14:12

Bertram Gilfoyle · Accepted Answer · 2018-08-25T10:26:39.543

addValueEventListener() is asynchronous. You will get the result only inside onDataChange(). Move the code to show notification into a separate method and call it inside onDataChange().

query.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(DataSnapshot dataSnapshot) {
                final Intent intent = new Intent(BackgroundService.this, NextActivity.class);
                Task < String > t = genrate(); //not null

                t.addOnCompleteListener(new OnCompleteListener < String > () {
                    @Override
                    public void onComplete(@NonNull Task < String > task) {
                        if (task.isSuccessful()) {
                            intent.putExtra("token", task.getResult());

                            //Show notification here
                            showNotification(intent);
                        }
                    }
                });

                @Override
                public void onCancelled(DatabaseError databaseError) {

                }
            });
});

Separate method to show notification.

private void showNotification(Intent intent) {
    intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, 0);
    mBuilder.setContentIntent(pendingIntent).setAutoCancel(true);
    mBuilder.setVisibility(VISIBILITY_SECRET);
    NotificationManagerCompat notificationManager = NotificationManagerCompat.from(BackgroundService.this);
    notificationManager.notify(121, mBuilder.build());
}

score 0 · Answer 3 · edited Aug 25 '18 at 12:07

0

Does your task.getResult() returns string? If yes, then try this in second activity.

Bundle extras = getIntent().getExtras();
if (extras != null) {
    String result = extras.getString("token");                
    System.out.println("yeah"+result);
}

edited Aug 25 '18 at 12:07

Bertram Gilfoyle

9,899
6
42
67

answered Aug 25 '18 at 10:21

Ashish Kudale

1,230
1
27
51

score -1 · Answer 4 · edited Aug 25 '18 at 12:09

you are not calling startActivity(intent);

query.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(DataSnapshot dataSnapshot) {
                final Intent intent = new Intent(BackgroundService.this, NextActivity.class);
                Task < String > t = genrate(); //not null

                t.addOnCompleteListener(new OnCompleteListener < String > () {
                    @Override
                    public void onComplete(@NonNull Task < String > task) {
                        if (task.isSuccessful()) {
                            intent.putExtra("token", task.getResult());
                            startActivity(intent);
                        }
                    }
                });
                intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
                PendingIntent pendingIntent = PendingIntent.getActivity(BackgroundService.this, 0, intent, 0);
                mBuilder.setContentIntent(pendingIntent).setAutoCancel(true);
                mBuilder.setVisibility(VISIBILITY_SECRET);
                NotificationManagerCompat notificationManager = NotificationManagerCompat.from(BackgroundService.this);
                notificationManager.notify(121, mBuilder.build());

                @Override
                public void onCancelled(DatabaseError databaseError) {

                }
            });

Intent.putExtra (key,value) is not working

4 Answers4