Can't get xml from https with skiping certificate

Asked Aug 24 '18 at 08:51

Active Aug 24 '18 at 09:31

Viewed 60 times

I've read here How to do a https request with bad certificate?, but also go give error:

tls: server's certificate contains an unsupported type of public key: *dsa.PublicKey

Here is my code:

tr := http.DefaultTransport.(*http.Transport)
    tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}

    client := &http.Client{Transport: tr}

    response, err := client.Get(httpsUrl)

    if err != nil {
        fmt.Println(err)
        return
    }

    defer response.Body.Close()
    body, _ := ioutil.ReadAll(response.Body)

    c.JSON(200, gin.H{"payload": body})

How to fix that?

edited Aug 24 '18 at 09:31

asked Aug 24 '18 at 08:51

Шерзод Ёров

What line is the error refering to? Maybe provide a bit more of the stack trace so we can tell where the panic originates. – mkopriva Aug 24 '18 at 09:01
... but the linked solution initializes the config (`... .TLSClientConfig = &tls.Config{ ...`) and you don't, you just assign to the uninitialized config's field, so I assume that's where the panic originates. – mkopriva Aug 24 '18 at 09:04
... try https://play.golang.org/p/TBsVWAQxSZC – mkopriva Aug 24 '18 at 09:05
same error invokes – Шерзод Ёров Aug 24 '18 at 09:08
Then please update your question with the stack trace. – mkopriva Aug 24 '18 at 09:10
i'' updated question – Шерзод Ёров Aug 24 '18 at 09:13
what's on line `C:/Users/LolakovF/go/src/hpapi/routes/reports.go:19`? – mkopriva Aug 24 '18 at 09:14
defer response.Body.Close() – Шерзод Ёров Aug 24 '18 at 09:15
You first need to check for errors, and only if it's `nil` can you touch the `response`. – mkopriva Aug 24 '18 at 09:15
Example: https://play.golang.org/p/j9v3-Mm9E93 – mkopriva Aug 24 '18 at 09:16
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/178671/discussion-between---and-mkopriva). – Шерзод Ёров Aug 24 '18 at 09:18
That is, if `client.Get` returns a non-nil `err` then `response` is going to be `nil` and calling `defer response.Body.Close()` on a `nil` response is causing your runtime panic. – mkopriva Aug 24 '18 at 09:18
2

Aside: disabling TLS verification on the DefaultTransport is a *really* bad idea. You should create your own Transport instance. – Peter Aug 24 '18 at 09:55

Can't get xml from https with skiping certificate

0 Answers0