Properly using bindCallback with RXJS6 and DWR

Question

I'm currently using bindCallback the following (now deprecated) way:

const someMapping = (data) => { return { ... }};

public someCall(id) {
  // Foo.someFunction is function with callbacks
  return this.toObservable(Foo.someFunction, someMapping, id);
}

private toObservable(func, mappingFunction, ...args: any[]) {
  return bindCallback(func, mappingFunction)(...args);
}

Other than this being deprecated, I have another issue. If I call the someFunction manually:

var callFn = function(data) {...}
var warnFn = function(data) {...}
var errFn = function(data) {...}
Foo.someFunction(id, {callback: callFn, warningHandler: warnFn, errorHandler: errFn})

It will throw success, warnings and errors correctly. I didn't create this DWR callback function (there are many of them), and I can't change them. Documentation isn't helping enough.

How can I modify this to handle all three (success, warning, error) callbacks and return as observables? Warning and error can both throw an error.

What's the signature of `someFunction`? And what's your question? — a better oliver, Jul 26 '18 at 14:07
It's actually DWR function. `Foo.someFunction = function (p0, p1, p2, _48) { ... };` where p0-p2 are parameters and _48 is callback, got around 150 functions like this. And this callback can somehow return one or three callbacks as in example above. — Bojan Kogoj, Jul 27 '18 at 08:29
I'm still not sure what you want to know. Your question does not contain an actual question. — a better oliver, Jul 29 '18 at 16:16

score 2 · Accepted Answer · answered Jul 30 '18 at 11:18

The best option is to create your own observable.

public someCall(id) {
  return new Observable(observer => {
                         Foo.someFunction(id,
                           {
                            callback: value => {
                                                 observer.next(value);
                                                 observer.complete();
                                               },
                            warningHandler: warn => observer.error(warn),
                            errorHandler: error => observer.error(error)
                          });

                        });

It's similar to calling someFunction manually but emits to a stream.

score 0 · Answer 2 · answered Jul 24 '18 at 13:11

0

From bindCallback documentation

The input is a function func with some parameters, the last parameter must be a callback function that func calls when it is done.

If I understand correctly your code

bindCallback(func, mappingFunction)

func is actually Foo.someFunction.

If I look at Foo.someFunction this is not a function with a callback function as its last parameter, as it is required by bindCallback.

So I am wondering if this code has ever worked.

answered Jul 24 '18 at 13:11

Picci

16,775
13
70
113

Current code works, but only for success callback. This also works `Foo.someFunction(id, function(data) {...});` which is why `bindCallback` works I suppose. – Bojan Kogoj Jul 24 '18 at 13:17

Properly using bindCallback with RXJS6 and DWR

2 Answers2