getting selected radiobutton text as string

Question

I have created two activity one for registration details and another one for showing the value user has entered. But when I tried to get the value of radiobutton from the radiogroup selected. It doesn't show any error but when I debug and run in my phone. And clicked the signup button It show app stopped working start again message

My MainActivity.java :

import android.app.DatePickerDialog;
import android.app.Dialog;
import android.app.TimePickerDialog;
import android.content.Intent;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.ArrayAdapter;
import android.widget.Button;
import android.widget.Spinner;
import android.widget.TextView;
import android.widget.Toast;

import java.util.Calendar;

public class MainActivity extends AppCompatActivity {


    Button signUpButton,signInButton;
    TextView userTimeJoining, dateOfBirth;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        signInButton = findViewById(R.id.signinbutton);
        signInButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

            }
        });

        signUpButton = findViewById(R.id.signupbutton);
        signUpButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

                Intent gotoRegAct = new Intent(MainActivity.this, RegistrationActivity.class);
                startActivity(gotoRegAct);


            }
        });

    }
}

My RegistrationActivity.java :

import android.app.DatePickerDialog;
import android.app.TimePickerDialog;
import android.content.Intent;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.AdapterView;
import android.widget.ArrayAdapter;
import android.widget.Button;
import android.widget.DatePicker;
import android.widget.EditText;
import android.widget.RadioButton;
import android.widget.RadioGroup;
import android.widget.Spinner;
import android.widget.TextView;
import android.widget.TimePicker;
import android.widget.Toast;

import java.util.Calendar;

public class RegistrationActivity extends AppCompatActivity {


    String courseList[] = {"Java","Python", "Android", "Kotlin"};


    Button submitButton;
    EditText nameOfUser, userGmail, userName, userPassword;
    TextView userDateOfBirth, userTimeOfJoining;
    Spinner mySpinnerForCourse;
    RadioGroup genderSelected;
    RadioButton selectedRadiobutton;


    String setTime;
    String setDate;
    String setGender=" ";
    int itemNoSelected;




    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_registration);




        submitButton = findViewById(R.id.submitButton);
        nameOfUser = findViewById(R.id.nameofuser);
        userGmail = findViewById(R.id.usergmail);
        userName = findViewById(R.id.username);
        userPassword = findViewById(R.id.userpassword);
        userDateOfBirth = findViewById(R.id.userdateofbirth);
        userTimeOfJoining = findViewById(R.id.usertimeofjoining);
        mySpinnerForCourse = findViewById(R.id.usercourse);
        genderSelected = findViewById(R.id.usergender);

       //This is the code which is not working
        int selectedRadioButtonId = genderSelected.getCheckedRadioButtonId();
        selectedRadiobutton = (RadioButton) findViewById(selectedRadioButtonId);
        setGender = selectedRadiobutton.getText().toString();

        ArrayAdapter<String> arrayAdapterForCourse = new ArrayAdapter<>(this, android.R.layout.simple_spinner_dropdown_item,courseList);
        mySpinnerForCourse.setAdapter(arrayAdapterForCourse);

        mySpinnerForCourse.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener() {
            @Override
            public void onItemSelected(AdapterView<?> adapterView, View view, int i, long l) {
                itemNoSelected = i;
            }

            @Override
            public void onNothingSelected(AdapterView<?> adapterView) {

            }
        });


        userTimeOfJoining.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

                Calendar calendar = Calendar.getInstance();
                int hh = calendar.get(Calendar.HOUR);
                int mm = calendar.get(Calendar.MINUTE);

                TimePickerDialog timePickerDialog = new TimePickerDialog(RegistrationActivity.this, new TimePickerDialog.OnTimeSetListener() {
                    @Override
                    public void onTimeSet(TimePicker timePicker, int i, int i1) {
                        setTime = i+" : "+i1;
                        userTimeOfJoining.setText(setTime);
                    }
                },

                        hh, mm, false);
                timePickerDialog.show();

            }
        });

        userDateOfBirth.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Calendar calendar = Calendar.getInstance();
                int dd = calendar.get(Calendar.DAY_OF_MONTH);
                int mm = calendar.get(Calendar.MONTH);
                int yy = calendar.get(Calendar.YEAR);

                DatePickerDialog datePickerDialog = new DatePickerDialog(RegistrationActivity.this, new DatePickerDialog.OnDateSetListener() {
                    @Override
                    public void onDateSet(DatePicker datePicker, int i, int i1, int i2) {
                        setDate = i2+" / "+i1+" / "+i;
                        userDateOfBirth.setText(setDate);
                    }
                }, yy, mm, dd);
                datePickerDialog.show();
            }
        });

        submitButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent gotoShowInfo = new Intent(RegistrationActivity.this, ShowInfo.class);

                Bundle bundleforenteredvalue = new Bundle();

                bundleforenteredvalue.putString("enteredname",nameOfUser.getText().toString());
                bundleforenteredvalue.putString("enteredgmail",userGmail.getText().toString());
                bundleforenteredvalue.putString("enteredusername",userName.getText().toString());
                bundleforenteredvalue.putString("enteredpassword",userPassword.getText().toString());
                bundleforenteredvalue.putString("dateselected",setDate);
                bundleforenteredvalue.putString("timeselected",setTime);
                bundleforenteredvalue.putString("genderselected",setGender);
                bundleforenteredvalue.putString("courseselected",courseList[itemNoSelected]);

                gotoShowInfo.putExtras(bundleforenteredvalue);

                startActivity(gotoShowInfo);
            }
        });


    }
}

My ShowInfo.java :

import android.content.Intent;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;

public class ShowInfo extends AppCompatActivity {


    TextView nameOfUserEntered, usernameEntered, passwordEntered,gmailEntered, genderSelected, courseSelected, dateOFJoinSelected, timeOfJoinSelected;


    Button signInButtonAgain;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_show_info);

        Bundle getValue = getIntent().getExtras();
        String getnameentered = getValue.getString("enteredname");
        String getenteredGmail = getValue.getString("enteredgmail");
        String getenteredUsername = getValue.getString("enteredusername");
        String getenteredPassword = getValue.getString("enteredpassword");
        String getdateSelected = getValue.getString("dateselected");
        String gettimeSelected = getValue.getString("timeselected");
        String getgenderSelected = getValue.getString("genderselected");
        String getcourseSelected = getValue.getString("courseselected");


        nameOfUserEntered = findViewById(R.id.nameofuserentered);
        usernameEntered = findViewById(R.id.usernameentered);
        passwordEntered = findViewById(R.id.passwordentered);
        gmailEntered = findViewById(R.id.gmailentered);
        genderSelected = findViewById(R.id.genderselected);
        courseSelected = findViewById(R.id.courseselected);
        dateOFJoinSelected = findViewById(R.id.dateofjoinselected);
        timeOfJoinSelected = findViewById(R.id.timeofjoinselected);
        signInButtonAgain = findViewById(R.id.signinbuttonagain);

        nameOfUserEntered.setText("Welcome "+ getnameentered);
        usernameEntered.setText("Your username is "+getenteredUsername);
        passwordEntered.setText("Your password is "+getenteredPassword);
        gmailEntered.setText("Your gmail is "+getenteredGmail);
        genderSelected.setText("Your gender is the "+getgenderSelected);
        courseSelected.setText("You selected for the "+getcourseSelected+" Course");
        dateOFJoinSelected.setText("your joinig date is "+getdateSelected);
        timeOfJoinSelected.setText("Time of your duty is starts from "+gettimeSelected);

        signInButtonAgain.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent gotoMainmenu = new Intent(ShowInfo.this, MainActivity.class);
                startActivity(gotoMainmenu);
            }
        });


    }
}

In registration activity I've added a comment by only that code my app show the error message. If I remove the radiobutton code and the getString String. It works properly and then it doesn't show app stopped working message. So why I'm not able to pass the value of the radiobutton string from one activity to another.

it shows no error. But when i open in my phone it shows app stopped working after clicking sign up button — A R DANISH, Jul 16 '18 at 12:16

Mohamed Mohaideen AH · Accepted Answer · 2018-07-16T14:59:34.023

1

Try this may be your radiobutton id returns -1 if no values are selected in radio group.

int chk_gender = rg_gender.getCheckedRadioButtonId();
            if (chk_gender != -1) {
                Gender = ((RadioButton)findViewById(chk_gender)).getText().toString();
            }
            else
            {
                Gender = "";
            }

EDITED

rg_gender.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
        @Override
        public void onCheckedChanged(RadioGroup group, int checkedId) {
            if (checkedId != -1) {
                Gender = ((RadioButton)findViewById(checkedId)).getText().toString();
            }
            else
            {
                Gender = "";
            }
        }
    });

edited Jul 16 '18 at 14:59

answered Jul 16 '18 at 12:43

Mohamed Mohaideen AH

2,527
1
16
24

thank you now it not showing any error. But every time it's returning -1. I don't know why – A R DANISH Jul 16 '18 at 13:21
@ARDANISH but what now? you can't get value. – Mohamed Mohaideen AH Jul 16 '18 at 13:22
why radiobutton returning -1 every time even after selecting the radiobutton – A R DANISH Jul 16 '18 at 13:23
@ARDANISH you have added value of radiobutton ID in your xml? – Mohamed Mohaideen AH Jul 16 '18 at 13:24
You need to get ID after submit button fired during oncreate it always be -1. Also you can implement checkedchangelistener of radiogroup to get values at that time of select. – Mohamed Mohaideen AH Jul 16 '18 at 13:27
Yes I've given ID to the radiobutton which is inside radiogroup – A R DANISH Jul 16 '18 at 14:53
You can change your code to get value in oncreate method.See edited answer. – Mohamed Mohaideen AH Jul 16 '18 at 15:00
yes I did that. I put the code inside the submit button onclicklistener and it worked. Thank you – A R DANISH Jul 16 '18 at 15:04
Welcome glad to help. – Mohamed Mohaideen AH Jul 16 '18 at 15:06

score 0 · Answer 2 · answered Jul 16 '18 at 12:28

In your xml layout ,did you checked TRUE any radio button ? You should get the selected radio button value on click of submit button.It will update your setGender string with most recent value. for your app crash , Please post your logcat error while app crash.

getting selected radiobutton text as string

2 Answers2