Exporting Excel getting this error Trying to get property 'id' of non-object

Question

I'm using Maatwebsite Laravel Excel package 3.0. This is my InvoicesExport.php

    class InvoicesExport implements FromCollection
{
    public function collection()
    {
        $company_id = Auth::user()->company_id;
         $assets = Asset::where('id', $company_id)->get()->toArray();    
         $assets_array = array();
        if(!$assets->isEmpty()){
         foreach($assets as $asset){
             $assets_array[] = array(
             'Asset ID' => $asset->id,
             'Asset Name' => $asset->name,
             'Description' => $asset->description,
             'Serial Number' => $asset->serialno,
             'External ID' => $asset->external_id,
             'Location' => $asset->location,
             'Expiry Date' => $asset->expiry_date,
             'Owner' => $asset->owner,
             'Status' => $asset->status,
             'Updated at' => $asset->updated_at
             );
            }
        }
        //dd($assets_array); 
        return $assets_array;
    }
}

And i keep getting this error

Trying to get property 'id' of non-object

And this is my function in controller

public function excel() 
    {    
          return Excel::download(new InvoicesExport, 'invoices.xlsx');
    }

My code looks like this now and I keep getting this error.

Call to a member function each() on array

When i use dd($assets_array) I get those 2 items that i have in database, so i think maybe it's problem in my RETURN

score 1 · Accepted Answer · answered Jun 25 '18 at 13:36

1

It seems, the problem is outside of the InvoicesExport Class.

Why don't you change the type of return?

instead of returning

return $assets_array;

Do it like this:

return collect($assets_array);

answered Jun 25 '18 at 13:36

Bak87

219
3
9

You sir, are my HERO! Thanks a lot <3 – Nemanja Jun 25 '18 at 13:53
`$assets = Asset::where('id', $company_id)->get()->toArray(); ` This line still doesn't work. I only get first asset from table. – Nemanja Jun 25 '18 at 13:57
How many records do you have in that table that has id = $company_id? If you have only one, you are going to get one. – Bak87 Jun 25 '18 at 14:13

ali · Answer 2 · 2018-06-25T11:22:16.767

0

you convert the collection to array and try to access it as object just remove the toArray

    $assets = Asset::where('id', $company_id)->get();

edited Jun 25 '18 at 11:22

answered Jun 25 '18 at 11:16

ali

832
6
11

After changing everything like that i get this error `Call to a member function each() on array` – Nemanja Jun 25 '18 at 11:20
just remove toarray from this $assets = Asset::where('id', $company_id)->get()->toArray(); – ali Jun 25 '18 at 11:21
I did, it's still same. – Nemanja Jun 25 '18 at 11:22
return your code as it was and just remove the toarray – ali Jun 25 '18 at 11:23
are you return the code as it was and remove the to array? – ali Jun 25 '18 at 11:24
Yes sir, I put everything back and just removed toArray(), and it's still same. – Nemanja Jun 25 '18 at 11:26
check if the $assets has data by make dd($assets); – ali Jun 25 '18 at 11:27
`Call to a member function each() on array` – Nemanja Jun 25 '18 at 11:27
put the foreach inside if(!$assets->isEmpty()) – ali Jun 25 '18 at 11:29
I got this `Collection {#965 ▼ #items: array:1 [▶] }` – Nemanja Jun 25 '18 at 11:30
I got this again `Call to a member function each() on array ` – Nemanja Jun 25 '18 at 11:32

Exporting Excel getting this error Trying to get property 'id' of non-object

2 Answers2