UserDefault is not saving the value

Question

I have a survey form that appear only if the user still didn't answer survey every time the user launch the app. But even if I already answered the survey still its appearing. Here's how I'm doing it

//Get if questionaire is done
let defaults = UserDefaults.standard
if let questionaire_done = defaults.string(forKey: "questionaire_done") {
    print(questionaire_done) // Some String Value
}else {
    performSegue(withIdentifier: "questionaireSegue", sender: nil)
}

UserDefaults.standard.set("yes", forKey: "questionnaire_done") //set the questionnaire as done

Key name is different "questionaire_done" and "questionnaire_done" how it will work. Set and Get key both name are different please change that first and check. — Hardik Thakkar, Jun 20 '18 at 10:29

Anbu.Karthik · Answer 1 · 2018-06-20T10:21:09.423

1

Store the value in before segue (navigation)

//Get if questionaire is done
let defaults = UserDefaults.standard
if let questionaire_done = defaults.string(forKey: "questionnaire_done")  {
    print(questionaire_done) // Some String Value
}else {
    defaults.set("yes", forKey: "questionnaire_done") //set the questionnaire as done
    performSegue(withIdentifier: "questionaireSegue", sender: nil)
}

If you want to validate your condition then you like

let defaults = UserDefaults.standard
if let questionaire_done = defaults.string(forKey: "questionnaire_done"), questionaire_done == "yes" {
    print(questionaire_done) // Some String Value
}else {
    defaults.set("yes", forKey: "questionnaire_done") //set the questionnaire as done
    performSegue(withIdentifier: "questionaireSegue", sender: nil)
}

edited Jun 20 '18 at 10:21

answered Jun 20 '18 at 10:02

Anbu.Karthik

82,064
23
174
143

Key name is different "questionaire_done" and "questionnaire_done" how it will work. Set and Get key both name are different please change that @Anbu.karthik also make same mistake for key. – Hardik Thakkar Jun 20 '18 at 10:20
@HardikThakkar - thanks for the info, i modified the answr – Anbu.Karthik Jun 20 '18 at 10:21
@user9900611 - your key name is different `questionnaire_done` from this `questionaire_done` – Anbu.Karthik Jun 20 '18 at 10:22

score 1 · Answer 2 · answered Jun 20 '18 at 10:18

1

if let questionaire_done = defaults.string(forKey: "questionaire_done")

has a different key to

UserDefaults.standard.set("yes", forKey: "questionnaire_done")

Spell the keys the same, or better still, use a constant string for the key.

answered Jun 20 '18 at 10:18

jrturton

118,105
32
252
268

score -1 · Answer 3 · answered Jun 20 '18 at 10:59

-1

Yes, the key value name should be always same but one more thing - you should write this after any "UserDefaults" operation - either read or write.

UserDefaults.standard.synchronize()

Example -

UserDefaults.standard.set("yes", forKey: "questionnaire_done")
UserDefaults.standard.synchronize()

answered Jun 20 '18 at 10:59

Rahul Singha Roy

548
1
3
13

3

You absolutely do not need to do this. It even says so in the docs https://developer.apple.com/documentation/foundation/userdefaults/1414005-synchronize. All that method does is wait. – jrturton Jun 20 '18 at 13:51

UserDefault is not saving the value

3 Answers3