For me these solutions were not that satisfying. I like general solutions where i don't have to adjust them, when adjusting the enum values. So i created the following solution, using the XmlAttributeOverrides
.
Solution 1
public static XmlAttributeOverrides ReflectionAddXmlEnumAttributes(Type baseType, XmlAttributeOverrides overrides = null)
{
if (overrides == null) overrides = new XmlAttributeOverrides();
// traversing all serializable members
var filteredFields = baseType.GetFields()
.Where(f =>
(f.Attributes.HasFlag(FieldAttributes.Public) &&
!f.Attributes.HasFlag(FieldAttributes.Static) &&
!f.CustomAttributes.Any(
a => a.AttributeType.IsAssignableFrom(typeof(XmlIgnoreAttribute)))));
var filteredProperties = baseType.GetProperties()
.Where(f =>
(f.GetMethod?.Attributes.HasFlag(MethodAttributes.Public) ?? false) &&
!f.GetMethod.Attributes.HasFlag(MethodAttributes.Static) &&
(f.SetMethod?.Attributes.HasFlag(MethodAttributes.Public) ?? false) &&
!f.SetMethod.Attributes.HasFlag(MethodAttributes.Static) &&
!f.CustomAttributes.Any(
a => a.AttributeType.IsAssignableFrom(typeof(XmlIgnoreAttribute))));
var classMemberTypes = filteredFields.Select(f => f.FieldType)
.Concat(filteredProperties.Select(p => p.PropertyType));
foreach (var memberType in classMemberTypes)
{
// proceed the same way for sub members
ReflectionAddXmlEnumAttributes(memberType, overrides);
if (!memberType.IsEnum) continue;
var enumFields = memberType.GetFields();
foreach (var enumFieldInfo in enumFields)
{
if (!enumFieldInfo.IsLiteral) continue;
// add attribute-overrides for every enum-literal
var name = enumFieldInfo.Name;
if (overrides[memberType, name] != null) continue;
var integer = enumFieldInfo.GetRawConstantValue();
var attribute = new XmlAttributes
{
XmlEnum = new XmlEnumAttribute(integer.ToString()),
};
overrides.Add(memberType, name, attribute);
}
}
return overrides;
}
public static T MyDeserialize<T>(string filePath)
{
var overrides = ReflectionAddXmlEnumAttributes(typeof(T));
var serializer = new XmlSerializer(typeof(T), overrides);
using (var fileStream = new FileStream(filePath, FileMode.Open, System.IO.FileAccess.Read))
{
var deserialized = serializer.Deserialize(fileStream);
fileStream.Close();
return (T) deserialized;
}
}
public static void MySerialization<T>(T serializeObject, string filePath)
{
var overrides = ReflectionAddXmlEnumAttributes(typeof(T));
var serializer = new XmlSerializer(typeof(T), overrides);
using (var writer = new StreamWriter(filePath))
{
serializer.Serialize(writer, serializeObject);
writer.Close();
}
}
For me the disadvantage of this solution is, that it's quiet much code and it then can handle only numerical types. I search for a solution, where it is possible to handle different strings for one enum literal, so it is possible to accept the numerical representation as also the name of the enum.
Solution 2
Because my first solution was not long enough, i created another solution, so i have my own serializer class, that can be used for accepting all kinds of serialized enums (string as also the number interpretation).
using System;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Security.Policy;
using System.Xml.Serialization;
namespace MyApp.Serializer
{
public class XmlExtendedSerializer : XmlSerializer
{
public SerializerDirection Mode { get; }
public XmlAttributeOverrides Overrides { get; }
public Type BaseType { get; }
public XmlExtendedSerializer(SerializerDirection mode, Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, string defaultNamespace, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out _, serializeEnumsAsNumber, overrides), extraTypes, root, defaultNamespace)
{
BaseType = type;
Mode = mode;
Overrides = overrides;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, XmlRootAttribute root, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber), null, root, null)
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, Type[] extraTypes, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber), extraTypes, null, null)
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, XmlAttributeOverrides overrides, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber, overrides))
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(XmlTypeMapping xmlTypeMapping)
{
throw new NotImplementedException("This method is not supported by this wrapper.");
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber))
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, string defaultNamespace, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber), null, null, defaultNamespace)
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, string defaultNamespace, string location, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber, overrides), extraTypes, root, defaultNamespace, location)
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public XmlExtendedSerializer(SerializerDirection mode, Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, string defaultNamespace, string location, Evidence evidence, bool serializeEnumsAsNumber = true) : base(type, AddXmlEnumAttributes(mode, type, out var overrideCreated, serializeEnumsAsNumber, overrides), extraTypes, root, defaultNamespace, location, evidence)
{
BaseType = type;
Mode = mode;
Overrides = overrideCreated;
}
public new object Deserialize(Stream stream)
{
if (Mode != SerializerDirection.Deserialize) throw new NotSupportedException("Wrong mode.");
UnknownElement += ConvertEnumEvent;
return base.Deserialize(stream);
}
public new void Serialize(TextWriter writer, object o)
{
if (Mode != SerializerDirection.Serialize) throw new NotSupportedException("Wrong mode.");
base.Serialize(writer, o);
}
private static XmlAttributeOverrides AddXmlEnumAttributes(SerializerDirection mode, Type baseType, out XmlAttributeOverrides outOverrides, bool serializeEnumsAsNumber = true, XmlAttributeOverrides overrides = null)
{
if (overrides == null) overrides = new XmlAttributeOverrides();
// traversing all serializable members
var filteredFields = baseType.GetFields()
.Where(f =>
(f.Attributes.HasFlag(FieldAttributes.Public) &&
!f.Attributes.HasFlag(FieldAttributes.Static) &&
!f.CustomAttributes.Any(
a => a.AttributeType.IsAssignableFrom(typeof(XmlIgnoreAttribute)))));
var filteredProperties = baseType.GetProperties()
.Where(f =>
(f.GetMethod?.Attributes.HasFlag(MethodAttributes.Public) ?? false) &&
!f.GetMethod.Attributes.HasFlag(MethodAttributes.Static) &&
(f.SetMethod?.Attributes.HasFlag(MethodAttributes.Public) ?? false) &&
!f.SetMethod.Attributes.HasFlag(MethodAttributes.Static) &&
!f.CustomAttributes.Any(
a => a.AttributeType.IsAssignableFrom(typeof(XmlIgnoreAttribute))));
foreach (var member in filteredFields.Cast<object>().Concat(filteredProperties))
{
var memberType = (member as FieldInfo)?.FieldType ?? ((PropertyInfo) member).PropertyType;
var name = (member as FieldInfo)?.Name ?? ((PropertyInfo)member).Name;
// proceed the same way for sub members
AddXmlEnumAttributes(mode, memberType, out _ , serializeEnumsAsNumber, overrides);
var deepEnumType = Nullable.GetUnderlyingType(memberType);
var isNullable = deepEnumType != null;
if (!isNullable) deepEnumType = memberType;
if (!deepEnumType.IsEnum) continue;
if (mode == SerializerDirection.Deserialize) // set ignore for enums and mark them for our own deserializer
{
var attributeIgnore = new XmlEnumConvertAttribute // with custom type to detect
{
XmlIgnore = true, // ignore all enums
};
overrides.Add(baseType, name, attributeIgnore);
}
else if (serializeEnumsAsNumber) // serialize as number
{
var enumFields = deepEnumType.GetFields();
foreach (var enumFieldInfo in enumFields)
{
if (!enumFieldInfo.IsLiteral) continue;
// add attribute-overrides for every enum-literal
var literalName = enumFieldInfo.Name;
if (overrides[memberType, literalName] != null) continue;
var integer = enumFieldInfo.GetRawConstantValue();
var attribute = new XmlAttributes
{
XmlEnum = new XmlEnumAttribute(integer.ToString()) // sets the number as output value
};
overrides.Add(memberType, literalName, attribute);
}
}
}
outOverrides = overrides;
return overrides;
}
// will be triggered on unknown xml elements are detected (enums are now marked as not serializable so they are unknown)
private void ConvertEnumEvent(object sender, XmlElementEventArgs e)
{
var memberName = e.Element.Name; // enum property/field name
var targetObject = e.ObjectBeingDeserialized;
var baseType = targetObject.GetType(); // type of including class
if (!(Overrides[baseType, memberName] is XmlEnumConvertAttribute)) return; // tag is really unknown
var text = e.Element.InnerText; // the value text from xml
var member = baseType.GetField(memberName);
var property = baseType.GetProperty(memberName);
var enumType = member?.FieldType ?? property.PropertyType;
enumType = Nullable.GetUnderlyingType(enumType) ?? enumType;
var newValue = string.IsNullOrEmpty(text) ?
null :
Enum.Parse(enumType, text); // enum parser accepts also string type and number-type
property?.SetValue(targetObject, newValue);
member?.SetValue(targetObject, newValue);
}
// custom type to detect on event, that this property was not ignored intentionally
private class XmlEnumConvertAttribute : XmlAttributes { }
}
public enum SerializerDirection
{
Serialize,
Deserialize
}
}
With the call like
var serializer = new XmlExtendedSerializer(SerializerDirection.Serialize, typeof(T));
using (var writer = new StreamWriter(path))
{
serializer.Serialize(writer, objectToSerialize);
writer.Close();
}
and
var serializer = new XmlExtendedSerializer(SerializerDirection.Deserialize, typeof(T));
using (var fileStream = new FileStream(path, FileMode.Open, System.IO.FileAccess.Read))
{
var tmpObj = serializer.Deserialize(fileStream);
fileStream.Close();
var deserializedObject = (T) tmpObj;
}
The downsides are:
- nullbale enums are always serialized to the string
- creating one instance of the serializer can only be used for one mode serialize OR deserialize not for both at the same time
- not all overloads of
Deserialize
and Serialize
are overridden
- own class