RxJS Migration 5 to 6 - Unsubscribe with TakeUntil

Question

What is the best way to unsubscribe in RxJS 6?

My 'old' RxJS 5 code looks this

export class MyComponent implements OnInit, OnDestroy {
  private ngUnsubscribe: Subject<any> = new Subject();

  this.myService.myEventEmitter
    .takeUntil(this.ngUnsubscribe)
    .subscribe(this.onDataPolling.bind(this));

  public ngOnDestroy(): void {
    this.ngUnsubscribe.next();
    this.ngUnsubscribe.complete();
  }
}

On migration to RxJS 6 i run rxjs-5-to-6-migrate and got

this.myService.myEventEmitter.pipe(
  takeUntil(this.ngUnsubscribe))
  .subscribe(this.onDataPolling.bind(this));

but this is not working because EventEmitter has no pipe method.

What is the best way to unsubscribe in RxJS 6?

Edit: This did work after a clean install and is the best way to unsubscribe in RxJS 6.

That's not true. `EventEmitter` extends `Subject` that extends `Observable` so it does have `pipe()` method. The problem will be somewhere else. — martin, May 30 '18 at 14:10
you right in my service i'm using import { EventEmitter } from "@angular/core". But what is the best way to migrate this??? — Juri, May 30 '18 at 14:21
But what's the problem with it? `myEventEmitter.pipe(...)` is correct so it doesn't work or it doesn't compile or what? — martin, May 30 '18 at 14:23
Property "pipe" is not available for type "EventEmitter<{}>" And got a couple of other migration errors... — Juri, May 30 '18 at 14:46
I have a similar problem with `takeUntil`, I'll post details of that tonight. — Khalid, Jun 04 '18 at 04:10
i think something was wrong with my imported packages. The code is ok and works fine after clean reinstall — Juri, Jul 10 '18 at 07:57

score 10 · Answer 1 · answered Sep 02 '18 at 07:17

10

import { takeUntil } from 'rxjs/operators';

.pipe(takeUntil(this.destroyed$)).subscribe({YOUR_CODE})

This should help.

answered Sep 02 '18 at 07:17

Paresh Varde

1,084
3
16
39

score -3 · Answer 2 · answered Jul 09 '18 at 14:47

-3

this.ngUnsubscribe.complete();

To

this.ngUnsubscribe.unsubscribe();

answered Jul 09 '18 at 14:47

Taha Zgued

1,088
12
18

4

i don't think this is correct. This are two different ways to unsubscribe https://blog.codecentric.de/en/2018/01/different-ways-unsubscribing-rxjs-observables-angular/ – Juri Jul 10 '18 at 07:55

RxJS Migration 5 to 6 - Unsubscribe with TakeUntil

2 Answers2