scala: whether the following two are the same

Question

Code piece 1

maps foreach { case (k, v) =>
  // do something
}

code piece 2:

maps foreach { 
  case (k, v) => {
    // do something
  }
}

I am new to scala. Just wonder whether the above two pieces of codes are the same or not? which one is better?

Thanks

They are the same in this instance (only one case). I personally like the first better if there's only one case, the second if there's more than one. — Alvaro Carrasco, May 15 '18 at 21:35

score 2 · Accepted Answer · answered May 15 '18 at 21:37

2

Yes, those two pieces of code are same.

But unfortunately none of them takes into account the recommendations of the Scala style guide.

Omitting dots and using spaces is not recommended.
Always omit braces in case clauses.
case may be present on same line or on the next line: it depends on the contents of // do something.

So the original code should be formatted as

maps.foreach {
  case (k, v) => // do something
}

answered May 15 '18 at 21:37

Antot

as for point 3, you mean `case (k, v) =>` and `// do something` may be on the same line? – BAE May 15 '18 at 21:46
Yes, everything in this example may be on the same line, if `// do something` is short and concise. – Antot May 15 '18 at 21:51

1 Answers1