Images not showing properly in listview in android

Question

I am downloading multiple attachments then writing images in sdcard but my problem is that when display image from sdcard on list showing half black image I am using picasso image loader for show images from sdcard. I getting same problem with glide images loader. see screenshot

Note: Image is getting downloaded properly when I see it in sdcard.

//showing image from sdcard

Picasso.get().load(uri).resize(200, 200).centerCrop().into(holder.imageAttach);

//Code Download Image by URL and write in sdcard

URL url = new URL(urlString);//Create Download URl
HttpURLConnection urlConnection = (HttpURLConnection) url.openConnection();//Open Url Connection
urlConnection.setRequestMethod("GET");//Set Request Method to "GET" since we are getting data
urlConnection.connect();//connect the URL Connection
double fileSize = 0;

//Create New File if not present
if (!filePath.exists()) {
    filePath.createNewFile();
}

//If Connection response is not OK then show Logs
if (urlConnection.getResponseCode() != HttpURLConnection.HTTP_OK) {
    Log.e("AutoDownloader", "Server returned HTTP "
        + urlConnection.getResponseCode()
        + " " + urlConnection.getResponseMessage());
}

BufferedOutputStream fos = new BufferedOutputStream(new FileOutputStream(filePath));//Get OutputStream for NewFile Location

InputStream is = urlConnection.getInputStream();//Get InputStream for connection

byte[] buffer = new byte[1024];//Set buffer type
int len1 = 0;//init length
while ((len1 = is.read(buffer)) != -1) {
    fos.write(buffer, 0, len1);//Write new file
}

//Close all connection after doing task
fos.close();
is.close();

Log.i("AutoDownloader", "downloadAttachmentInByte startDownload success");
try{
    ((Activity)ContextHelper.getContext()).runOnUiThread(new Runnable() {
        @Override
                public void run() {
                        progressBar.setVisibility(View.GONE);
                }
         });
} catch (Exception e){
     e.printStackTrace();
}

score 1 · Answer 1 · answered Apr 27 '18 at 06:22

I think your images are not getting downloaded properly. I would suggest to Let the Picasso do the whole work for you. -

Target target = new Target() {  
    @Override
    public void onBitmapLoaded(Bitmap bitmap, Picasso.LoadedFrom from) {
        holder.imageAttach.setImageBitmap(bitmap);
          new Thread(new Runnable() {

                    @Override
                    public void run() {

                        File file = new File(Environment.getExternalStorageDirectory().getPath() + "/" + url);
                        try {
                            file.createNewFile();
                            FileOutputStream ostream = new FileOutputStream(file);
                            bitmap.compress(Bitmap.CompressFormat.JPEG, 80, ostream);
                            ostream.flush();
                            ostream.close();
                        } catch (IOException e) {
                            Log.e("IOException", e.getLocalizedMessage());
                        }
                    }
                }).start();
    }

    @Override
    public void onBitmapFailed(Drawable errorDrawable) {}

    @Override
    public void onPrepareLoad(Drawable placeHolderDrawable) {}
};

  Picasso.with(getApplicationContext())
      .load(photoUrl)
      .resize(200, 200)
      .into(target);

Image is getting downloaded properly when I see it in sdcard. — hharry_tech, Apr 27 '18 at 06:31

Gowthaman M · Answer 2 · 2018-04-27T07:24:24.983

0

try adding android:scaleType="fitXY" to your ImageView.

Picasso.get().load(uri).resize(200, 200).centerCrop().into(holder.imageAttach);

replace simply use this

  holder.imageAttach.setImageURI(uri)

edited Apr 27 '18 at 07:24

answered Apr 27 '18 at 06:14

Gowthaman M

8,057
8
35
54

I tried same according to your answer but getting same problem – hharry_tech Apr 27 '18 at 06:18
.resize(200, 200) remove this line,,add in hight and width of imageview 200,200 in xml...check once let me kbow...check my updated answer as well – Gowthaman M Apr 27 '18 at 06:23
you are displaying image from **Uri** ro **URL** – Gowthaman M Apr 27 '18 at 06:53
@hharry_tech check my updated answer....take android default features..no need to use Picasso...i hope you pbm will get reslove – Gowthaman M Apr 27 '18 at 07:25
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/169920/discussion-between-gowthaman-m-and-hharry-tech). – Gowthaman M Apr 27 '18 at 07:37
Actually I have to use any image loader for display images on listview for manage smooth scrolling... thats way I am using picasso / glide. There will image, video, auto and document file in listview so I have maintain smooth scrolling – hharry_tech Apr 27 '18 at 07:54
@hharry_tech ok then simply use **if condition** if it's image uri use `holder.imageAttach.setImageURI(uri)` – Gowthaman M Apr 27 '18 at 08:02

Dnyaneshwar Panchal · Answer 3 · 2018-04-27T07:40:15.867

0

You just remove resize(200,200) and use only fit().

Picasso.with(this).load(uri).fit().into(holder.imageAttach);

edited Apr 27 '18 at 07:40

answered Apr 27 '18 at 07:34

Dnyaneshwar Panchal

444
4
13

Images not showing properly in listview in android

3 Answers3