What's wrong? C

Question

I wanna compare an element of a string with a char, what's wrong? i get segmentation fault.

i wanna go trough a string, copyng the part of string until an element of string, when the element=",", but i'm making something of wrong.

passing argument 1 of ‘strcmp’ makes pointer from integer without a cast

     char palavra[1000],linha[1000];
     int i;

     while(fgets(linha, sizeof(linha), df)!=NULL){

                i=0;
                strcopy(palavra,"0");                    

                while(strcmp(&linha[i],",")!=0){

                    strcpy(&palavra[i],&linha[i]);
                    i++;                    

                }
      printf("%s,",palavra);
      }

passing argument 1 of ‘strcmp’ makes pointer from integer without a cast — Carlos Monteiro, Apr 23 '18 at 16:32
You don't need `strcmp` to compare chars. Just compare them directly. — Christian Gibbons, Apr 23 '18 at 16:32
The title here is to tell us what this question is about. Yours has zero value. — Eugene Sh., Apr 23 '18 at 16:50

score 1 · Answer 1 · answered Apr 23 '18 at 16:36

1

You should not be using strcmp to compare individual char, it is meant for comparing full strings. If you just want to compare individual elements, you would just compare them directly: linha[i] == ','

Same applies for copying a char.

answered Apr 23 '18 at 16:36

Christian Gibbons

4,272
1
16
29

score 1 · Answer 2 · answered Apr 23 '18 at 16:41

should be

           while(linha[i] != ','){

                palavra[i] = linha[i];
                i++;                    

            }

Although I am a bit suspicious of palavra[i] assignment since that overwrites the strcpy of 0 done before the loop

Mesar ali · Answer 3 · 2018-04-23T17:41:33.937

-1

You are passing address, not value &linha[i]
to use strcmp(), both strings should be null terminated(\0)

So, use if as

for( i=0; i < len; i++)          
    if(linha[i]!=',')

edited Apr 23 '18 at 17:41

answered Apr 23 '18 at 16:35

Mesar ali

1,832
2
16
18

should be `!= ','` – pm100 Apr 23 '18 at 17:01
still got "," instead of ',' – pm100 Apr 23 '18 at 17:40

What's wrong? C

3 Answers3