klocwork issue for std::ofstream open

Question

Klocwork throws

resource acquired to 'ofs.open("file.txt", std::ofstream::out)' may be lost here

for the below piece of code.

#include <iostream>
#include <fstream>

void main()
{
    std::ofstream ofs;
    ofs.open("file.txt", std::ofstream::out);
    if (ofs.is_open())
    {
        std::cout << "file open success\n";
    }
    ofs.close();
}

I dont find any issues with the above code. Can someone explain what need to be done here to fix the issue.

My guess would be "false positive by the tool" - hard to avoid, there's always going to be some of those.. — Jesper Juhl, Apr 19 '18 at 18:28
It might be because a variable is not assigned to the result of `ofs.open("file.txt", std::ofstream::out);`? — EM-Creations, Nov 01 '18 at 10:15

score 3 · Accepted Answer · answered Oct 02 '18 at 20:05

Are you still having this issue? I have a workaround that satisfies Klocwork: use RAII:

std::ofstream ofs( "file.txt", std::ios::binary );

If that doesn't work, use a temp.

        std::ofstream temp( "file.txt", std::ios::binary );
        if( !temp.is_open() )
        {
            temp.close();
        }
        else
        {
            m_outStream = std::move( temp );
        }

klocwork issue for std::ofstream open

1 Answers1